MCP stdio: optional Linux PR_SET_PDEATHSIG so a server dies with its parent even on SIGKILL / panic=abort

Aperta
#414 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
bash, linux, rust
Ambito
devtools

Direzione di ricerca

Start with the stdio spawn path that sets kill_on_drop(true) and own_process_group, and the StdioOptions builder, to see where a die_with_parent option would hook in. The design question is whether PR_SET_PDEATHSIG should fire on the forking thread's exit under Tokio, so read how tokio::process::Command::spawn forks before writing code. Tests belong in tests/mcp_stdio_test.rs, gated to Linux, covering the SIGKILL case, a control without the option, and the getppid guard. Done means the option works, non-Linux behaviour is decided and documented, and the tests pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Asked for by: yoyo-evolve (its #1100). An MCP stdio server should not outlive the host process.

What yoagent does today (0.26.6):

  • Every stdio server is spawned with kill_on_drop(true).
  • StdioOptions::new().own_process_group(true) (0.25.16) puts the server in its own process group. That group is killed on close or drop, and since 0.26.0 also as soon as the command's own exit is seen (an npx → node launcher).
  • A panic that unwinds drops the McpClient, so the server goes too.

The gap: when the parent dies without running destructors, nothing kills the server. That happens on SIGKILL, OOM-kill, panic = "abort", or std::process::exit without dropping the client. The server, and in a process group everything it started, keeps running, reparented to init.

Proposal: an opt-in, Linux-only StdioOptions::die_with_parent(true).

  • In a pre_exec hook it calls prctl(PR_SET_PDEATHSIG, SIGKILL) (via libc, already a cfg(unix) dependency), then checks getppid() against the parent's pid captured before the fork. If the parent is already gone, the child exits. This is the documented race guard.
  • It sits beside own_process_group. The death signal reaches only the direct child (the launcher), so it pairs with own_process_group: the launcher dying is then seen by the existing group cleanup only if yoagent is still alive. Document that a server started through a launcher (npx) may leave grandchildren behind on a SIGKILLed parent, unless the launcher itself forwards the signal.
  • On non-Linux targets, return an error from the builder, or make it a documented no-op (decide which). macOS has no PDEATHSIG; a kqueue NOTE_EXIT watcher in a helper process would be a separate, larger design.
  • Caveat to document: PR_SET_PDEATHSIG fires when the thread that forked exits, not the process. Tokio spawns from a runtime worker thread, so a worker thread exiting (runtime shutdown with the client still alive) would kill the server early. Verify how tokio::process::Command::spawn forks, and whether this needs spawning from a long-lived thread, before choosing the default semantics.

Tests: Linux-only (#[cfg(target_os = "linux")]), in tests/mcp_stdio_test.rs style:

  • Spawn a helper process that starts a bash-scripted server with the option set, record the server's pid, SIGKILL the helper, and assert the server is gone within a bound.
  • A control test without the option: the server survives, then clean it up.
  • The getppid race guard.

Not in scope: changing the default. The option is opt-in, and hosts that already supervise their children (systemd, containers) don't need it.

Lingua principale
Rust
Stelle
327
Fork
46
Merge medio
2h 36m
PR unite (30g)
107

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di yologdev/yoagent

Tutte le issue di yologdev/yoagent

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.