DuckDB: spatial join on a GEOMETRY column of an Arrow scan fails (EXPRESSION_FILTER pushdown) — draft for upstream

Aperta
  • Qualcosa non va?
#278 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
28/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend, databases

Direzione di ricerca

The report identifies DuckDB’s Python Arrow scan and SPATIAL_JOIN filter pushdown as the failure path, but this is a draft for upstream DuckDB rather than a change scoped to this repository. Start by checking the reported reproduction against DuckDB 1.5.5 with PyArrow 23.0.0; done means unsupported filters are skipped and applied after the scan, allowing the join to return 4. The issue also raises a separate CRS documentation mismatch without specifying a file to change.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

A draft for DuckDB upstream, filed here for review first.

Summary

A spatial join in DuckDB fails when one side is an Arrow scan whose geometry column is a native GEOMETRY, meaning a GeoArrow WKB column (ARROW:extension:name = geoarrow.wkb). The failure:

NotImplementedException: Not implemented Error: Pushdown Filter Type EXPRESSION_FILTER is not currently supported in PyArrow Scans

The SPATIAL_JOIN operator pushes a filter on the geometry column into the Arrow scan, which the Python Arrow scan can't translate. DuckDB raises an error instead of skipping that pushdown and filtering after the scan.

This breaks the most common geospatial query on xarray-sql tables: xql.register(con, name, ds, geometry=(x, y)) produces exactly such a column, and joining it to a table of polygons with ST_Within fails. A constant polygon works; a polygon from a table, a join, or a scalar subquery fails.

Repro, without xarray-sql (DuckDB 1.5.5, pyarrow 23.0.0)

import duckdb, struct, json, pyarrow as pa, pyarrow.dataset as pads

con = duckdb.connect()
con.execute("INSTALL spatial; LOAD spatial")
xy = [(x, y) for y in (0.0, 1.0, 2.0) for x in (0.0, 1.0, 2.0)]
wkb = pa.array([struct.pack("<BIdd", 1, 1, x, y) for x, y in xy], pa.binary())
geometry = pa.field("geometry", pa.binary(), metadata={
    "ARROW:extension:name": "geoarrow.wkb",
    "ARROW:extension:metadata": json.dumps({"crs": "OGC:CRS84"}),
})
points = pa.Table.from_arrays([wkb], schema=pa.schema([geometry]))
con.execute("""CREATE TABLE p AS SELECT ST_SetCRS(ST_GeomFromText(
    'POLYGON((-0.5 -0.5, 1.5 -0.5, 1.5 1.5, -0.5 1.5, -0.5 -0.5))'), 'OGC:CRS84') AS geom""")

for obj in (points, pads.dataset(points)):
    con.register("g", obj)
    con.sql("SELECT count(*) FROM g JOIN p ON ST_Within(g.geometry, p.geom)").fetchone()
    # NotImplementedException: ... EXPRESSION_FILTER ... PyArrow Scans

Results by query shape, on an xarray-sql table registered with geometry=("longitude", "latitude"):

Query Result
WHERE ST_Within(geometry, ST_GeomFromText('POLYGON ...')) (constant) works
WHERE ST_Within(geometry, (SELECT geom FROM p)) fails
JOIN p ON ST_Within(g.geometry, p.geom) fails
FROM g, p WHERE ST_Within(g.geometry, p.geom) fails
FROM (FROM g LIMIT ...) g JOIN p ON ... fails
JOIN p ON ST_Within(ST_Point(g.longitude, g.latitude), p.geom) works
CREATE TABLE gm AS FROM g, then join gm works

The same join on a plain binary column, ST_Within(ST_GeomFromWKB(g.wkb), p.geom), also works. So the trigger is the native GEOMETRY type on an Arrow scan.

Setting disabled_optimizers to join_filter_pushdown, filter_pushdown or both doesn't change it.

Expected

The Arrow scan should decline filters it can't translate, as it does for other expressions, and DuckDB should apply them after the scan, so the join returns 4.

Workarounds today

  • Build the point in the join: ST_Point(longitude, latitude). This loses the CRS tag.
  • Copy the table into DuckDB first with CREATE TABLE ... AS.

For xarray-sql

  • Until DuckDB is fixed, the geospatial docs could show the ST_Point form for joins against polygon tables.
  • A related mismatch: xarray-sql tags its points OGC:CRS84, while DuckDB's ST_Read tags GeoJSON (always longitude/latitude on WGS84) EPSG:4326. ST_Within then refuses with "Cannot call function 'ST_Within' with geometries of different coordinate reference systems". Users have to pass geometry_crs="EPSG:4326" or use ST_SetCRS. That deserves a line in the docs, or a separate issue on which default fits DuckDB better.
Lingua principale
Python
Stelle
142
Fork
19
Merge medio
3g 47m
PR unite (30g)
8

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di xqlsystems/xarray-sql

Tutte le issue di xqlsystems/xarray-sql

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.