Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

pyproject.toml: [tool.setuptools_scm] is inert — maturin takes the version from Cargo.toml

Aperta
  • Qualcosa non va?
#244 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
45/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
python, rust
Ambito
build-system, release

Direzione di ricerca

The inert section is [tool.setuptools_scm] near line 110 of pyproject.toml, while dynamic = ["version"] on line 7 is resolved by maturin from rust/Cargo.toml. Confirm that by building a wheel and checking its version against Cargo.toml. Done means the maintainers have picked an option: either remove the section so Cargo.toml is clearly the single source, or make SCM actually drive the version. Optionally add a tag-vs-version check to the publish workflow. The issue has no comments yet, so pick the direction with a maintainer first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Third one from modelling ddx's packaging on this repo (after #242 and #243) — this one I checked empirically rather than by reading, because I was about to copy the pattern.

pyproject.toml declares SCM versioning:

[project]
dynamic = ["version"]     # L7
...
[tool.setuptools_scm]     # L110

but setuptools-scm is never installed at build time:

[build-system]
requires = ["maturin>=1.9,<2.0"]
build-backend = "maturin"

and maturin is the backend, not setuptools — it does not consult setuptools-scm at all. For dynamic = ["version"], maturin takes the version from Cargo.toml.

How I checked

I put the identical configuration on ddx's own maturin package — dynamic = ["version"], [tool.setuptools_scm], and (unlike here) setuptools-scm actually present in build-system.requires — in a repo with no matching git tag at all. SCM versioning would have had to produce a 0.1.x.dev...+g<sha> string. The build produced:

📦 Built wheel ... ddxdb-0.1.0-cp310-abi3-macosx_11_0_arm64.whl

0.1.0 is exactly the Cargo.toml version. Git was never consulted.

So [tool.setuptools_scm] here is inert configuration: the published version is whatever rust/Cargo.toml says, and the section reads as though tags drive it. That is harmless today but misleading — someone bumping a tag and expecting the wheel to follow would be surprised, and the failure is silent.

Options

  1. Drop [tool.setuptools_scm] and treat rust/Cargo.toml as the single source, which is what already happens. Optionally assert tag-vs-version in the publish workflow so a mismatched tag fails the release rather than shipping.
  2. Actually use SCM, which means not using maturin's version handling — e.g. generate the version in CI and pass --version / rewrite Cargo.toml before building. More machinery than it is likely worth.

I went with (1) plus a tag check in ddx. Happy to send a PR here if useful.

Lingua principale
Python
Stelle
142
Fork
19
Merge medio
1g 6h
PR unite (30g)
10

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di xqlsystems/xarray-sql

Tutte le issue di xqlsystems/xarray-sql

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.