[Bug]: IdentitiesOnly=yes incorrectly disables SSH agent authentication with a public IdentityFile

Aperta
#3,595 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go
Ambito
backend, security

Direzione di ricerca

Start in pkg/remote/sshclient.go, especially createClientConfig() and createPublicKeyCallback(), which the issue identifies as the agent initialization and identity parsing entry points. Read how configured IdentityFile values and agent keys are handled, then locate the SSH client tests for regression coverage. Done means matching agent keys can authenticate with IdentitiesOnly enabled, while unrelated keys remain excluded; the issue asks for coverage with the setting both enabled and disabled.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug triage
Current Behavior

Wave Terminal fails to authenticate using an SSH agent when IdentitiesOnly yes is specified in ~/.ssh/config, even when IdentityFile explicitly identifies a public key whose corresponding private key is available through the agent.
The same configuration works correctly with the native OpenSSH client on Windows.
This appears to be an incompatibility with OpenSSH's documented IdentitiesOnly behavior.

Environment
OS: Windows 11
SSH agent: Bitwarden SSH Agent
SSH client comparison: Windows OpenSSH (ssh.exe)
Wave Terminal version: [insert installed version]

The private key is managed by Bitwarden and is not stored as a local file. The corresponding public key is stored locally.

Expected Behavior

Expected Behavior

According to OpenSSH's ssh_config(5) documentation:
IdentityFile may point to a public key file when the corresponding private key is managed by an SSH agent.
IdentitiesOnly yes restricts authentication to the explicitly configured identities.
It does not disable SSH agent authentication.
The SSH client should request signatures from the agent only for keys matching the configured identities.
Therefore, Wave should successfully authenticate using the matching Bitwarden-managed private key, without trying unrelated identities from the agent.

Actual Behavior

Wave appears to disable SSH agent authentication entirely when IdentitiesOnly yes is enabled, causing authentication to fail because the specified .pub file cannot be used directly as a private key.

Steps To Reproduce

Configure Bitwarden as the system SSH agent and ensure the corresponding key is available through the agent.

Add the following entry to ~/.ssh/config:

Host testserver
HostName 192.0.2.10
User root
IdentityFile C:/path/to/myhome.pub
IdentitiesOnly yes

Replace the example address and public key path with a working SSH server and the appropriate public key.

Run ssh testserver in PowerShell. Authentication succeeds.

Connect to the same host using Wave Terminal's built-in SSH connection. Authentication fails with:

ssh: handshake failed: ssh: unable to authenticate,
attempted methods [none publickey],
no supported methods remain

Comment out IdentitiesOnly yes, without changing anything else, and retry. Both Windows OpenSSH and Wave Terminal now connect successfully.

Wave Version

0.14.5

Platform

Windows 11

OS Version/Distribution

26H2

Architecture

x86_64

Anything else?

Possible Root Cause

In pkg/remote/sshclient.go, createClientConfig() contains:

if !utilfn.SafeDeref(sshKeywords.SshIdentitiesOnly) && agentPath != "" {
conn, err := dialIdentityAgent(agentPath)
// ...
}

This condition skips SSH agent initialization whenever IdentitiesOnly is true.

Additionally, createPublicKeyCallback() attempts to parse configured identity files as private keys using ssh.ParseRawPrivateKey(), without implementing the OpenSSH behavior of matching a public IdentityFile against the keys available from the agent.

Source:
https://github.com/wavetermdev/waveterm/blob/main/pkg/remote/sshclient.go

OpenSSH reference:
https://man.openbsd.org/ssh_config#IdentitiesOnly

Suggested Fix

Allow SSH agent initialization regardless of the IdentitiesOnly setting.
When IdentitiesOnly is true, filter agent-provided identities against the public keys specified by IdentityFile.
Support public-key-only IdentityFile entries, including .pub files, when the associated private key is held by the agent.
Add regression tests covering both IdentitiesOnly yes and no, with and without a matching agent key.

Workaround

Setting IdentitiesOnly no allows Wave to connect successfully.
However, this workaround changes authentication behavior by allowing additional keys from the SSH agent to be attempted. It is not equivalent to the intended OpenSSH behavior.
The issue affects SSH agents that manage private keys externally, including Bitwarden and potentially hardware-backed SSH agents.

Lingua principale
Go
Stelle
22.7k
Fork
1.2k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di wavetermdev/waveterm

Tutte le issue di wavetermdev/waveterm

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.