Make the file size limit configurable (drag-and-drop / file upload via wsh)

Aperta
#3,560 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
45/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go, typescript
Ambito
cli, frontend

Direzione di ricerca

Start with the hard-coded MaxFileSize and checkFileSize in cmd/wsh/cmd/wshcmd-file.go, then the constant in pkg/wshrpc/wshrpctypes_const.go and the gate in frontend/app/view/preview/preview-model.tsx. The config key naming lives in pkg/wconfig/metaconsts.go and defaultconfig.go. Done means a config key replaces the three limits, falls back to a default when config is unavailable to wsh, and is documented in docs/docs/config.mdx. Ask the maintainers whether to use one setting or separate keys before choosing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Make the file size limit configurable (drag-and-drop / file upload via wsh)

Summary

File transfers that go through the wsh file path have a hard-coded size limit, and that
limit cannot be changed by any user-facing setting. Dragging files between widgets hits this
limit, so large files simply fail — and since the limit is not configurable, there is no
supported way to raise it. I would like the limit to become a config setting.

Wave Version

0.14.5

OS

macOS 26.2 (arm64)

The problem

The limit is a hard-coded constant in three separate places, rather than a single shared
setting:

Value Location Purpose
10MB cmd/wsh/cmd/wshcmd-file.go:26 (MaxFileSize) Caps the file transfer / write path. Enforced in checkFileSize, in the stdin writer, and on append (including a remainingSpace check that caps appends to the same total).
50MB pkg/wshrpc/wshrpctypes_const.go (MaxFileSize) RPC-layer cap for reading files.
10MB frontend/app/view/preview/preview-model.tsx:34 (MaxFileSize) Frontend preview gate, with a separate MaxCSVSize of 1MB.

So wsh file put / the drag-and-drop upload path cannot carry a file larger than 10MB, and
there is no way to raise it. Attempting to send a larger file errors out with
input exceeds maximum file size of 10485760 bytes (or file already at maximum size), which
at least fails loudly on the CLI side — but when the transfer is triggered by a drag gesture
there is no progress feedback at all, so the failure is easy to miss (see #3559).

Because the limit lives in compiled code, the only ways around it today are to work outside
Wave (scp / rsync from a terminal block) or to edit and rebuild the binary.

Steps to reproduce

  1. Open a local preview widget and a remote preview widget side by side.
  2. Drag a file larger than 10MB (e.g. a 200MB video or archive) from the local preview into
    the remote preview directory.
  3. The transfer fails, because the wsh file path caps the transfer at 10MB.
  4. Confirm there is no setting to raise it — searching the config docs / wsh config for a
    file-size option turns up nothing; app:* config keys cover things like app:tabbar and
    app:defaultnewblock, but nothing about transfer size.

Expected behavior

  • The file size limit should be a user-facing config setting, so it can be raised without
    rebuilding.
  • The setting should be respected consistently across all three call sites above. Right now
    each has its own constant, so even a partial fix would leave the others capping the transfer.
  • Ideally the limits should be unified into a single constant that reads from config, rather
    than three independent values that can drift apart.

Suggested configuration

Following the existing naming convention in pkg/wconfig/metaconsts.go (app:<lowercase>),
something in this shape would fit:

app:filesizelimit      # bytes, for the wsh file transfer / drag-and-drop upload path
app:filepreviewlimit   # bytes, for the frontend preview gate (currently 10MB)
app:csvpreviewlimit    # bytes, for the CSV preview gate (currently 1MB)

Worth considering whether the preview limits should be separate from the transfer limit at all,
or whether preview and transfer can share one setting — preview has a legitimate reason to stay
small (it is about whether a file can be rendered inline), whereas transfer does not.

Implementation notes

The main work is mechanical:

  • Add the config key(s) in pkg/wconfig/metaconsts.go and register them in
    pkg/wconfig/defaultconfig/defaultconfig.go / pkg/wconfig/settingsconfig.go following the
    existing app:* pattern.
  • Replace the constants in cmd/wsh/cmd/wshcmd-file.go and pkg/wshrpc/wshrpctypes_const.go
    with a value read from the config. The wsh side would need access to the Wave config rather
    than relying on a package-level const.
  • Update the frontend gates in frontend/app/view/preview/preview-model.tsx to read the
    configured value instead of the local const.
  • Add a line to docs/docs/config.mdx for the new key.

One caveat worth flagging: wsh can run standalone against a remote host, where it may not
have the local Wave config available. It may be worth keeping a sane default and only applying
the configured value when config is reachable, rather than assuming config is always present.

Anything else?

Happy to submit a PR for this — it is mostly replacing constants with config lookups plus a
docs line, and I am comfortable with the pattern used by the existing app:* keys. Please let
me know if you would prefer the three limits unified into one setting rather than exposed
separately; I can go either way.

Related: #3559 (drag-and-drop transfers have no progress feedback) and #929 / #1685
(drag-and-drop between widgets / Xftp-style transfer). This is the piece that currently puts a
ceiling on any of those working with real files.

Lingua principale
Go
Stelle
22.7k
Fork
1.2k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di wavetermdev/waveterm

Tutte le issue di wavetermdev/waveterm

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.