Habitat: map synonymous terms from different sources to one

Aperta
  • Qualcosa non va?
#300 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
77/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
r
Ambito
data

Direzione di ricerca

Start with inst/extdata/attribute_synonyms.tsv and attributes.tsv, then inspect how the synonym table is applied to TRUE rows and how the vocabulary test checks for unused terms. Confirm the four proposed source terms have no FALSE rows, add their mappings, and remove terms from attributes.tsv only when no rows still use them. Done when the mappings pass the vocabulary check and the marine water body term remains unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Habitat is a multistate-union attribute, so the states of different sources add up and never compete. Sources use different words for the same place, though, and a search on one word misses the rows under the other.

Rows per term and source in physiologies("habitat"), with the Wikipedia_2026 source (#296) included:

Term Source Rows Same place as Rows
digestive system ProTraits 215 gastrointestinal tract (Wikipedia_2026 268, ProTraits 1) 269
hydrothermal vents ProTraits 45 hydrothermal vent (Wikipedia_2026 75, BacMap 5) 80
creosote contaminated soil ProTraits 3 creosote-contaminated soil (BacMap) 1
human microflora BacMap 2 human microbiome (ProTraits) 115
marine water body ProTraits 71, BacMap 20 91 sea water (Wikipedia_2026 625, BacMap 7) 632

Proposed change

Add rows to inst/extdata/attribute_synonyms.tsv for the first four, mapping the left term to the right one. Then remove the left terms from attributes.tsv if nothing else uses them.

marine water body to sea water is less clear, since a marine water body also has sediment. I would leave it unless someone wants it.

Leave alone

These are a source's own categories and have no equivalent elsewhere: colonization of host (507), multiple (318) and specialized (144) in BacMap; free-living (1,280), environmental system (92) and secondary (57) in ProTraits; waste and sludge water (797) in MiDAS. Broader terms such as aquatic biome and terrestrial biome are parents of the specific ones, not synonyms, so they stay too.

Wikipedia habitats are written only with terms bugphyzz already had, so that source needs nothing.

Check

The synonym table applies to rows with Attribute_value TRUE only. Confirm that the four left terms have no FALSE rows, which would keep the old term and fail the vocabulary test.

Raised while adding the Wikipedia source (waldronlab/bugphyzzExports#105).

Written with Claude Code.

Lingua principale
R
Stelle
6
Fork
6
Merge medio
3h 17m
PR unite (30g)
20

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di waldronlab/bugphyzz

Tutte le issue di waldronlab/bugphyzz

Issue simili

Altre issue su R

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.