Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Bug in xbps-create when a relative symlink point to an absolute symlink

Aperta
  • Qualcosa non va?
#435 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
c
Ambito
cli, tooling

Direzione di ricerca

Start by running the supplied reproduction script and inspect xbps-create's symlink handling around readlink and realpath. Compare the generated files.plist with the package contents, then verify that the corrected metadata lets xbps-remove remove both symlinks without truncating the target path.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Simple script to reproduce

#! /bin/sh

set -e

PKGVER=bug-1_1
ARCH=x86_64
DESC="Package to show a bug in xbps-create"

DESTDIR=/tmp/bug-1

mkdir -p $DESTDIR/etc/A
ln -s /etc/os-release $DESTDIR/etc/abs
ln -s ../abs $DESTDIR/etc/A/rel

xbps-create --arch "$ARCH" --desc "$DESC" --pkgver "$PKGVER" $DESTDIR

After running this script you'll end up with a badly formed package. Contents are ok:

$ tar tvf bug-1_1.x86_64.xbps
-rw-r--r-- root/root       503 1969-12-31 21:00 ./props.plist
-rw-r--r-- root/root       744 1969-12-31 21:00 ./files.plist
lrwxrwxrwx 0/0               0 2021-11-28 20:06 ./etc/abs -> /etc/os-release
lrwxrwxrwx 0/0               0 2021-11-28 20:06 ./etc/A/rel -> ../abs

But files.plist is wrong:

$ tar xOf bug-1_1.x86_64.xbps ./files.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>dirs</key>
	<array>
		<dict>
			<key>file</key>
			<string>/etc</string>
		</dict>
		<dict>
			<key>file</key>
			<string>/etc/A</string>
		</dict>
	</array>
	<key>links</key>
	<array>
		<dict>
			<key>file</key>
			<string>/etc/A/rel</string>
			<key>mtime</key>
			<integer>1638140801</integer>
			<key>target</key>
			<string>lease</string>
		</dict>
		<dict>
			<key>file</key>
			<string>/etc/abs</string>
			<key>mtime</key>
			<integer>1638140801</integer>
			<key>target</key>
			<string>/etc/os-release</string>
		</dict>
	</array>
</dict>
</plist>

What is going on I think is:

  • the file in destdir /etc/A/rel is a symlink and readlink gives ../abs which is understood to be relative since it starts with .
  • the filename is then canonicalized (using realpath) to /etc/os-release
  • since the symlink was thought to be relative, this is expected to be inside destdir
  • hence we drop the destdir prefix /tmp/bug-1, that's 10 characters so /etc/os-release minus 10 characters gives lease

This actually bit us in the wip sagemath package. The net result is that those symlinks that are badly reported in files.plistare not removed by xbps-remove.

I've since made a workaround in the sagemath package so this won't affect us, but it'd be nice to fix this logic (whiich is kind of hard to understand), at the very least check that the prefix for the link is indeed the destdir before droping it naively and complain if not.

All of this is affected by whether the canonicalized path is actually an existing file; that's why I chose /etc/os-release which should always exist (if this file is not there, the bug doesn't trigger).

Lingua principale
C
Stelle
1.2k
Fork
152
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di void-linux/xbps

Tutte le issue di void-linux/xbps

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.