chore(deps): bump both org-infra reviewer pins to v0.9.0 and update workflowtest constant
I maintainer di solito rispondono entro 1 giorno
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
Summary
internal/workflowtest/ci_dependencies_test.go asserts both org-infra reusable-workflow pins against a single shared orgInfraSHA constant. PR #152 bumps only the deps reviewer to v0.9.0, leaving the Dependabot reviewer on v0.8.0, so make check fails at ci_dependencies_test.go:124 and the required Build and Test check is red.
Decision: supersede #152 with a PR that bumps both org-infra reviewer references to v0.9.0 in lockstep, keeping the single shared constant. This is smaller than restructuring the test to support different versions.
Evidence
make check→--- FAIL: TestCIDependenciesWorkflow_StructureEnforcesGuardedApprovalatinternal/workflowtest/ci_dependencies_test.go:124- PR #152
Build and Testis PR-caused failing orgInfraSHA(bd3718a…, v0.8.0) is asserted againstreusable_deps_reviewer.yml(line 124) andreusable_dependabot_reviewer.yml(line 125), so a single-reference bump always breaks the shared constant
Upstream Verification (complytime/org-infra)
v0.9.0is a lightweight tag pointing at commit8f347ba1aa2c7e9eb3b70e69c1709ddb456cd64areusable_dependabot_reviewer.ymlexists at that SHA; v0.8.0 → v0.9.0 only adds outputs (org_precedent,precedent_detail) — non-breaking for consumersreusable_deps_reviewer.ymlv0.9.0 changesREVIEW_CONCLUSIONfromsteps.dependency_review.conclusionto.outcome. Because that step usescontinue-on-error: true, the old value was alwayssuccess, masking failed scans; failed scans now reportfailure
Proposed Fix
.github/workflows/ci_dependencies.yml:37— bumpreusable_dependabot_reviewer.ymlfrombd3718a… # v0.8.0to8f347ba… # v0.9.0internal/workflowtest/ci_dependencies_test.go:19— updateorgInfraSHAto8f347ba1aa2c7e9eb3b70e69c1709ddb456cd64a- Keep the single constant and the full 40-char SHA assertions intact. Pinned action SHAs are a protected gate value (AGENTS.md Gatekeeping Value Protection item 4); do not weaken them to green the test
Behaviour Change
Our workflow auto-approves only when review_conclusion == 'success'. After the bump, a failed dependency scan reports failure instead of being masked as success, so Dependabot auto-approval stops and the PR goes to manual review. This fails closed and is the intended upstream fix, not a regression. No consumer logic changes are required.
Acceptance Criteria
-
make checkpasses - Both org-infra reviewer references are pinned to
8f347ba1aa2c7e9eb3b70e69c1709ddb456cd64awith accurate# v0.9.0comments - Superseding PR merges and PR #152 is closed
- Behaviour change (auto-approval halts when the dependency scan fails) is noted in the PR description
Out of Scope
Other org-infra references remain on v0.8.0 (ci_checks.yml:34, release.yml:47,63). They are not coupled to this test constant and can be bumped separately.
Notes
Dependabot cannot modify repository test code, so this needs a maintainer-authored change. Pushing a commit onto the Dependabot branch risks being discarded on its next rebase, so a superseding PR from a normal branch is preferred.
- Lingua principale
- Go
- Stelle
- 0
- Fork
- 9
- Merge medio
- 1g 14h
- PR unite (30g)
- 18
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di unbound-force/replicator
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
unbound-force/replicator#95 ·
I maintainer di solito rispondono entro 1 giorno
-
bug github_actions
Difficoltà 2/5 Meno di un'ora Idoneità per principianti 80/100
unbound-force/replicator#89 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
unbound-force/replicator#85 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
unbound-force/replicator#77 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
unbound-force/replicator#63 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di unbound-force/replicator
Issue simili
-
area/networking kind/bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 69/100
siderolabs/talos#14972 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
kubectl wait outputs cryptic "error: unrecognized condition: []" when --for is omittedForse già presa @muskan-creates352 l’ha presa oggi. Apertakind/bug needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
kubernetes/kubectl#1910 · 1 commento ·
-
needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
stacklok/toolhive-catalog#1967 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
unbound-force/gaze#353 ·
I maintainer di solito rispondono entro 1 giorno