chore(deps): bump both org-infra reviewer pins to v0.9.0 and update workflowtest constant

Aperta
#156 1 commento 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@yvonnedevlinrh ci sta già lavorando.

Dal 9/11/2026.

  • #157 di @yvonnedevlinrh — aperta

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

bug

Summary

internal/workflowtest/ci_dependencies_test.go asserts both org-infra reusable-workflow pins against a single shared orgInfraSHA constant. PR #152 bumps only the deps reviewer to v0.9.0, leaving the Dependabot reviewer on v0.8.0, so make check fails at ci_dependencies_test.go:124 and the required Build and Test check is red.

Decision: supersede #152 with a PR that bumps both org-infra reviewer references to v0.9.0 in lockstep, keeping the single shared constant. This is smaller than restructuring the test to support different versions.

Evidence

  • make check → --- FAIL: TestCIDependenciesWorkflow_StructureEnforcesGuardedApproval at internal/workflowtest/ci_dependencies_test.go:124
  • PR #152 Build and Test is PR-caused failing
  • orgInfraSHA (bd3718a…, v0.8.0) is asserted against reusable_deps_reviewer.yml (line 124) and reusable_dependabot_reviewer.yml (line 125), so a single-reference bump always breaks the shared constant

Upstream Verification (complytime/org-infra)

  • v0.9.0 is a lightweight tag pointing at commit 8f347ba1aa2c7e9eb3b70e69c1709ddb456cd64a
  • reusable_dependabot_reviewer.yml exists at that SHA; v0.8.0 → v0.9.0 only adds outputs (org_precedent, precedent_detail) — non-breaking for consumers
  • reusable_deps_reviewer.yml v0.9.0 changes REVIEW_CONCLUSION from steps.dependency_review.conclusion to .outcome. Because that step uses continue-on-error: true, the old value was always success, masking failed scans; failed scans now report failure

Proposed Fix

  • .github/workflows/ci_dependencies.yml:37 — bump reusable_dependabot_reviewer.yml from bd3718a… # v0.8.0 to 8f347ba… # v0.9.0
  • internal/workflowtest/ci_dependencies_test.go:19 — update orgInfraSHA to 8f347ba1aa2c7e9eb3b70e69c1709ddb456cd64a
  • Keep the single constant and the full 40-char SHA assertions intact. Pinned action SHAs are a protected gate value (AGENTS.md Gatekeeping Value Protection item 4); do not weaken them to green the test

Behaviour Change

Our workflow auto-approves only when review_conclusion == 'success'. After the bump, a failed dependency scan reports failure instead of being masked as success, so Dependabot auto-approval stops and the PR goes to manual review. This fails closed and is the intended upstream fix, not a regression. No consumer logic changes are required.

Acceptance Criteria

  • make check passes
  • Both org-infra reviewer references are pinned to 8f347ba1aa2c7e9eb3b70e69c1709ddb456cd64a with accurate # v0.9.0 comments
  • Superseding PR merges and PR #152 is closed
  • Behaviour change (auto-approval halts when the dependency scan fails) is noted in the PR description

Out of Scope

Other org-infra references remain on v0.8.0 (ci_checks.yml:34, release.yml:47,63). They are not coupled to this test constant and can be bumped separately.

Notes

Dependabot cannot modify repository test code, so this needs a maintainer-authored change. Pushing a commit onto the Dependabot branch risks being discarded on its next rebase, so a superseding PR from a normal branch is preferred.

Lingua principale
Go
Stelle
0
Fork
9
Merge medio
1g 14h
PR unite (30g)
18

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di unbound-force/replicator

Tutte le issue di unbound-force/replicator

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.