Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Undo an interrupted theme update at startup instead of waiting for the next update

Aperta
  • Qualcosa non va?
#168 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
backend

Direzione di ricerca

Start with packages/builder-server/src/services/themeUpdateService.js and app/server-common.js; trace how interrupted theme updates are recovered and how startup processes projects. Check the existing update lock and recovery tests before deciding where startup recovery belongs. Done means a leftover interrupted update is undone at startup, with a test, or the issue is closed with reasoning that retrying the update already covers recovery.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

After a crash mid theme update the site looks broken until the update is pressed again.

Recovery (recoverInterruptedUpdate, themeUpdateService.js) runs only at the start of the next applyThemeUpdateToDir. Checked 2026-10-06 at 46119daa: after a crash mid-swap the update is still offered, because checkForUpdates compares the project row's themeVersion with the theme source, and the row is written only after applyThemeUpdateToDir returns. With notifications on (they must be, for the update to have been started), pressing "Apply update" again undoes the half-finished swap and applies the update cleanly. A crash after the plan file is removed but before the row write leaves new files under the old version; re-applying is harmless (noted in applyThemeUpdateExclusively). The remaining gap is the time until the user presses update again: folders such as assets/widgets sit inside .theme-update-backup, so pages render without them, a site export or backup made meanwhile omits them (dot-folders are excluded), and nothing tells the user the broken site and the update notice are connected. The same state follows an undo that itself failed ("The theme update could not be completed. Please try again."). Only a theme removed or downgraded meanwhile would leave nothing to trigger recovery.

Recommended: on server start, check each project for a leftover .theme-update-backup/ and run the recovery under the per-project update lock (a crash always means a restart), and export that as a function embedding apps can call per project. Optional: before a site export or backup, refuse with a clear message if an interrupted update could not be undone. Owner's alternative: close as covered by retrying the update.

Done when: A leftover interrupted update is undone at startup (or the task is closed with that reasoning), with a test.

Start: themeUpdateService.js, server-common.js. Source: 2026-10-05 code review of 48eef6f4..9e98dad7; narrowed 2026-10-06.

Lingua principale
JavaScript
Stelle
162
Fork
6
Merge medio
12h 55m
PR unite (30g)
2

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di tsiger/widgetizer

Tutte le issue di tsiger/widgetizer

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.