🐛 Bug Report: Bedrock instrumentation: uninstrument() does not remove tracing from clients created while instrumented
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 68/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- aws, python
- Ambito
- observability
Direzione di ricerca
Start with _wrap and _uninstrument in packages/opentelemetry-instrumentation-bedrock/opentelemetry/instrumentation/bedrock/__init__.py, then inspect the existing Bedrock instrumentation tests for client creation and teardown coverage. Reproduce with a client created before uninstrument() and verify it no longer emits spans afterward, including the async path if covered by the tests.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Which component is this bug for?
Bedrock Instrumentation
📜 Description
After BedrockInstrumentor().uninstrument(), a bedrock-runtime client that was created while the instrumentation was active keeps creating spans. Only clients created after uninstrument() are untraced. Clients are usually created once at start-up, so in practice uninstrument() has no effect on an application's existing clients (and on test suites that instrument / uninstrument around a shared client).
Cause: _wrap replaces the API methods on each new client instance (client.invoke_model = ..., client.converse = ..., and the streaming variants; same in the aiobotocore path), but _uninstrument only unwraps create_client. The replaced methods on existing clients are never restored, and the wrappers do not check whether the instrumentor is still active.
_wrapL166: https://github.com/traceloop/openllmetry/blob/df4921a40940cdce136c4409380a55e9d4c7a96d/packages/opentelemetry-instrumentation-bedrock/opentelemetry/instrumentation/bedrock/__init__.py#L166_uninstrumentL1259: https://github.com/traceloop/openllmetry/blob/df4921a40940cdce136c4409380a55e9d4c7a96d/packages/opentelemetry-instrumentation-bedrock/opentelemetry/instrumentation/bedrock/__init__.py#L1259
This is different from #4552 (OpenAI unwrap() being a no-op): here create_client is unwrapped correctly, but clients that already exist stay instrumented.
👟 Reproduction steps
pip install boto3 opentelemetry-instrumentation-bedrock opentelemetry-sdk
python repro.py
import json, logging
from importlib.metadata import version
logging.disable(logging.WARNING)
import boto3
from botocore.awsrequest import AWSResponse
from botocore.config import Config
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter
from opentelemetry.instrumentation.bedrock import BedrockInstrumentor
exporter = InMemorySpanExporter()
provider = TracerProvider()
provider.add_span_processor(SimpleSpanProcessor(exporter))
class Raw: # a canned Converse response, no network
def __init__(self, data): self.data = data
def stream(self, *a, **k): yield self.data
def read(self, amt=None): return self.data
def close(self): pass
release_conn = close
def before_send(request, **_):
out = {"output": {"message": {"role": "assistant", "content": [{"text": "hi"}]}}, "stopReason": "end_turn",
"usage": {"inputTokens": 3, "outputTokens": 1, "totalTokens": 4}, "metrics": {"latencyMs": 1}}
return AWSResponse(request.url, 200, {"content-type": "application/json"}, Raw(json.dumps(out).encode()))
def new_client():
c = boto3.client("bedrock-runtime", region_name="us-east-1", aws_access_key_id="x", aws_secret_access_key="x",
config=Config(retries={"total_max_attempts": 1}))
c.meta.events.register("before-send.bedrock-runtime.*", before_send)
return c
def spans_for(client):
exporter.clear()
client.converse(modelId="anthropic.claude-3-haiku-20240307-v1:0",
messages=[{"role": "user", "content": [{"text": "hi"}]}])
return len(exporter.get_finished_spans())
print("boto3", version("boto3"), "| opentelemetry-instrumentation-bedrock", version("opentelemetry-instrumentation-bedrock"))
BedrockInstrumentor().instrument(tracer_provider=provider)
early = new_client() # created while instrumented (typical: at app start-up)
print("instrumented: client created before ->", spans_for(early), "span(s)")
BedrockInstrumentor().uninstrument()
print("uninstrumented: client created before ->", spans_for(early), "span(s) (expected 0)")
print("uninstrumented: client created after ->", spans_for(new_client()), "span(s) (expected 0)")
👍 Expected behavior
After uninstrument(), no client creates spans, including clients created earlier.
Possible fixes: have the per-client wrappers call straight through to the original method once the instrumentor is uninstrumented (a flag checked at call time), or keep a weakref.WeakSet of instrumented clients and restore their original methods in _uninstrument.
👎 Actual Behavior with Screenshots
The client created before uninstrument() is still traced:
boto3 1.43.108 | opentelemetry-instrumentation-bedrock 0.62.4
instrumented: client created before -> 1 span(s)
uninstrumented: client created before -> 1 span(s) (expected 0)
uninstrumented: client created after -> 0 span(s) (expected 0)
🤖 Python Version
3.12
📃 Provide any additional context for the Bug.
OS: Ubuntu Linux. boto3 / botocore 1.43.108, opentelemetry-instrumentation-bedrock 0.62.4.
👀 Have you spent some time to check if this bug has been raised before?
- I checked and didn't find similar issue
Are you willing to submit PR?
Yes I am willing to submit a PR!
- Lingua principale
- Python
- Stelle
- 7.5k
- Fork
- 1.2k
- Merge medio
- 2g 6h
- PR unite (30g)
- 2
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di traceloop/openllmetry
-
🐛 Bug Report: OpenAI Responses: with_raw_response.create() raises when the body can't be parsed, though the uninstrumented call returnsForse già presa Una pull request collegata a questa issue è aperta o già unita. Apertabug python
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
traceloop/openllmetry#4717 ·
I maintainer di solito rispondono entro 1 giorno
-
🐛 Bug Report: Incomplete cache token migration after #4243 breaks Bedrock and Groq instrumentationForse già presa @Quantum-Enigma-dot l’ha presa 21 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
traceloop/openllmetry#4665 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
🐛 Bug Report: OpenAI instrumentation drops gen_ai.usage.reasoning_tokens on streamed chat completionsForse già presa @jayfeng7 l’ha presa 23 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
traceloop/openllmetry#4660 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Bug Report: Failed dataset deletes still remove local rows and columnsForse già presa @inchang-ing l’ha presa 32 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
traceloop/openllmetry#4630 ·
I maintainer di solito rispondono entro 1 giorno
-
🐛 Bug Report: LiteLLM instrumentation does not record seed, stop, frequency_penalty, presence_penaltyForse già presa @shantam77 l’ha presa 38 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
traceloop/openllmetry#4598 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di traceloop/openllmetry
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
mozilla-ai/cq#601 ·
I maintainer di solito rispondono entro 1 giorno
-
Bump Python to 3.14 or 3.15Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
I maintainer di solito rispondono entro 1 giorno
-
intcomma returns exponential notation for large floatsForse già presa @Omarinho12345 l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
python-humanize/humanize#521 ·
I maintainer di solito rispondono entro 1 giorno
-
LUCJ pass manager raises NoEdgeBetweenNodes when an edge is bad for two two-qubit gatesForse già presa @hat-im l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno
-
opensubtitlescom: provider rejects pt-PT even though its own converter maps itForse già presa @paulo-0308 l’ha presa oggi. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
Diaoul/subliminal#1405 ·