Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Test server: refused CancelTimer leaves the workflow task complete in memory but STARTED in history, so it is never timed out or redelivered

Aperta
#3,088 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java

Direzione di ricerca

Inizia da completeWorkflowTask e dalla sua operazione update(...), quindi segui TestWorkflowMutableStateImpl.processCancelTimer, timeoutWorkflowTask e fireTimer. Verifica come cambiano la macchina a stati della workflow task e la mappa dei timer quando l'elaborazione dei comandi genera un'eccezione. Il lavoro è completo quando un completamento rifiutato lascia la task recuperabile tramite timeout o WorkflowTaskFailed e una nuova consegna, e il comportamento del timer descritto è stato gestito o esplicitamente delimitato.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

test server

Expected Behavior

When RespondWorkflowTaskCompleted is refused because a command is invalid, the workflow task should be failed (WorkflowTaskFailed in history) and rescheduled, so the worker can replay and continue, which is what the real Temporal server does (for a cancel of an unknown timer it fails the task with BAD_CANCEL_TIMER_ATTRIBUTES; for a cancel of a timer whose TimerFired is still buffered, it drops the buffered fire and records TimerCanceled).

At minimum, a refused completion should leave the task in a state its own start-to-close timeout can act on.

Actual Behavior

A completion carrying a CancelTimer for a timer id the server no longer holds in its in-memory timers map is refused by TestWorkflowMutableStateImpl.processCancelTimer with:

code: INVALID_ARGUMENT, message: "invalid history builder state for action"

After that refusal the run never receives another workflow task. History ends

... TimerStarted -> WorkflowExecutionSignaled -> WorkflowTaskScheduled -> WorkflowTaskStarted

and stays there: no WorkflowTaskFailed, no WorkflowTaskTimedOut (the workflow's workflowTaskTimeout was 60 s; we observed 88 s with no event), no redelivery. sdk-core logs WARN Error while completing workflow activation and evicts the run; its subsequent polls return nothing. The workflow stays RUNNING forever.

From the source, the cause is the order of operations inside completeWorkflowTask's update(...):

workflowTaskStateMachine.action(StateMachines.Action.COMPLETE, ctx, request, 0);
for (Command command : commands) { processCommand(...); }

StateMachine.action assigns state immediately. When processCancelTimer throws, update rethrows and the RequestContext is discarded, but the state machine stays at NONE; nothing rolls it back. timeoutWorkflowTask then returns early on workflowTaskStateMachine.getState() == State.NONE, so the start-to-close timeout never produces WorkflowTaskTimedOut, and nothing schedules a new task. The same non-transactional pattern exists in fireTimer (timers.remove(timerId) inside the update lambda) and in processCancelTimer itself.

We could not establish from our side why the timer id was missing: it had been started by the immediately preceding completion 16 ms earlier, was one hour long, and the server's clock (read via getCurrentTime at the end of the test) had not jumped. The server cannot tell us either: the bundled binary carries no slf4j binding (logback-classic is testRuntimeOnly in temporal-test-server/build.gradle), so log.error("Failure firing a timer") and friends go to the NOP logger and nothing reaches stderr.

Related: #2127 (signal handling around the first WFT on the test server), #1377 (predictable log output from the test server).

Steps to Reproduce the Problem

We do not have a deterministic reproduction; it recurs at a low rate in CI. The shape that triggers it:

  1. Start the time-skipping test server (TestWorkflowEnvironment.createTimeSkipping from the TypeScript SDK) and a workflow whose loop re-arms a condition(..., timeout) timer on every turn (workflow task timeout 60 s).
  2. From the test, unlockTimeSkippingWithSleep for 2 days; the run processes ~48 hourly timers during the skip, sends a message via an activity, and its next dMarker x5, StartTimer(50)]`.
  3. Immediately after that completion (history shows TimerStarted -> WorkflowExecutionSignaled +1ms), signal the workflow. The worker answers the signal's taskelTimer(50), RecordMarker,ScheduleActivityTask, ScheduleActivityTask]`.
  4. The server refuses it as above; the run is stranded.

sdk-core DEBUG trace from the failing run (comevent ids, e.g. the refused task wasHistoryUpdate(previous_started_event_id: 646, started_id: 656, length: 10)) is available on request.

Suggested fixes:

  1. Perform the workflow-task state-machine transition after the commands validate, or roll it back when a completion is refused, so a refused task stays STARTED and its timeout (or a WorkflowTaskFailed) redelivers it.
  2. Treat CancelTimer for an already-fired-but-unseen timer the way the real server does (drop the buffered TimerFired, record TimerCanceled).
  3. Ship a logging binding in the test-server binary, or route the test service's log.error to stderr, so a refused completion is diagnosable.

Specifications

  • Version: temporal-test-server-sdk-typescrnloaded by @temporalio/testing1.16.1); the code paths above are unchanged onmaster` as of 2026-09-17
  • Platform: observed on GitHub Actions `ubun; the same sequence passes 25/25 locally on macOS 15 (Apple Silicon), so it is timing-dependent
  • Client: TypeScript SDK 1.16.1 (sdk-core),
Lingua principale
Java
Stelle
433
Fork
249
Merge medio
6g 5h
PR unite (30g)
25

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di temporalio/sdk-java

Tutte le issue di temporalio/sdk-java

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.