An abandoned start holds its interviewer slot for five minutes
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 43/100
Direzione di ricerca
Start by tracing /api/token and claim_and_dispatch, then inspect LocalDispatcher and the room task's candidate join timeout (CANDIDATE_JOIN_LIMIT). Identify how room ownership is authorized and how the existing no-show path releases consent; the proposed release endpoint should stop only an owned room that has not yet been joined. Done means an ended start releases its waiting slot promptly, while joined rooms and unauthorized callers are unaffected.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Follow-up to this review comment on #519.
By the time /api/token answers, claim_and_dispatch has already claimed consent and asked the dispatcher for an interviewer. LocalDispatcher reserves a slot and spawns the room task, and the slot is released only when that task returns. The agent then waits up to CANDIDATE_JOIN_LIMIT (300 s) for the candidate to join.
Since #519 the page can give up a start after the token response. If the candidate presses End while the Strict problem loads or while the LiveKit join is still in progress, connect stops the start and leaves any room it joined, but nothing tells the server. The agent waits for a candidate who will not come, and the slot counts against max_concurrent until the 300 s run out. A guest's slot also counts against the cap of two guest interviews. Other starts in that time can be refused with "The server is running as many interviews as it can right now." For a signed-in candidate, the consent claim stays until the no-show path releases it at the end of the wait.
Proposed fix:
- Once a token was granted,
abandonStartcalls a release endpoint with the room name, for examplePOST /api/token/release. - The server releases only a room the caller owns, and does nothing once the candidate has joined. A signed-in caller can be checked against the room authorization
/api/tokenalready grants. Guests get no such grant today, so they would need their own check, or could be left out at first. - The dispatcher stops the waiting room task, which drops the slot and releases consent through the existing no-show path.
A closed tab still waits out the 300 s, since nothing can send the call then. This only covers starts the page ends itself.
- Lingua principale
- Rust
- Stelle
- 215
- Fork
- 141
- Merge medio
- 1g 12h
- PR unite (30g)
- 228
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di sysprog21/codetrial
-
Audio output can be confirmed without playing a test soundForse già presa @ChenYingHan1121 l’ha presa 11 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
sysprog21/codetrial#359 · 6 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
-
Add update notifications for the prebuilt Windows binary ProblemForse già presa @Yu-Ming-Chang l’ha presa oggi. Aperta
sysprog21/codetrial#547 · 2 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Tell macOS binary users when a newer release is availableForse già presa @LJY2000-max l’ha presa oggi. Aperta
sysprog21/codetrial#543 · 2 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Web lobby cannot reopen Setup after configurationForse già presa @YEH-YU-YANG l’ha presa 2 giorni fa. Aperta
sysprog21/codetrial#525 · 3 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di sysprog21/codetrial
Issue simili
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
I maintainer di solito rispondono entro 1 giorno
-
o8 next debug build aborts on Glass to Dark appearance switch (nil identifier messaged before check)Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
hurttlocker/o8#5112 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 79/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
memory_patch_page drops the `#` of headings like `## Notes on C#`Forse già presa @viniciusdsandrade l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
akitaonrails/ai-memory#1859 ·
I maintainer di solito rispondono entro 1 giorno