`GlobalRuntimeState::$interpolatedVariables` is never reset, so long-running Antlers renders slow down without bound

Aperta
  • Qualcosa non va?
#15,814 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@lazerg ci sta già lavorando.

Dal 7/11/2026.

  • #15815 di @lazerg — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
laravel, php
Ambito
backend, performance

Direzione di ricerca

Read GlobalRuntimeState::resetGlobalState() and the append in DocumentParser.php (the issue gives line numbers for several branches). Check the existing runtime state reset tests, then verify that resetting clears interpolatedVariables and that repeated renders no longer accumulate entries. Issue #15815 is an open linked pull request, so check its status before starting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Bug description

DocumentParser appends to GlobalRuntimeState::$interpolatedVariables every time it parses a template with an interpolated region (DocumentParser.php line 1071 in 5.x, 1242 on master, 1462 in 6.39.0):

GlobalRuntimeState::$interpolatedVariables[] = $results[2];

Environment::getValue() then checks every StringValueNode in every condition against the whole list:

if (Str::contains($val->value, GlobalRuntimeState::$interpolatedVariables)) {

Nothing ever empties the list. GlobalRuntimeState::resetGlobalState(), called per request through StateManager::resetState() by the ClearState listener on RequestHandled and ResponseCreated, resets every other piece of runtime state (templateFileStack, yieldStacks, layoutVariables and so on) but not $interpolatedVariables.

Under PHP-FPM each request is a fresh process, so this goes unnoticed. In any long-lived process that renders many views (statamic/ssg with workers, queue workers rendering views, Octane), the list grows with every request and every condition gets slower.

Measured

Static site generation (statamic/ssg, --workers=4) of a ~3,900-page site, rendering in one PHP process:

  • The list grew by about 118 entries per page (about 95 unique), reaching 23,718 entries after 200 pages.
  • Mean render time per page rose from about 0.7s to 1.5 to 1.7s over 500 pages.
  • A sampling profile of early against late pages attributed the growth to Str::contains under Environment::getValue (about 56ms to 659ms per page).
  • Clearing the list after each request kept render time flat. 500 pages took 274s instead of 512s, and a full build roughly halved. Page output was byte-identical, apart from per-render uniqid() values.
How to reproduce

Render the same Antlers view many times in one process, with a template that has an interpolated tag parameter (for example {{ partial:card :title="{title}" }} or {{ link to="/x/{slug}" }}), and dispatch RequestHandled between renders as the HTTP kernel does. count(GlobalRuntimeState::$interpolatedVariables) grows on every iteration, and the cost of conditions grows with it.

Suggested fix

Clear it with the rest of the runtime state:

public static function resetGlobalState()
{
    self::$templateFileStack = [];
    // ...
    self::$interpolatedVariables = [];
    // ...
}

Optionally, de-duplicate on append, or store it as a set keyed by value, so even a single long request can't grow it with duplicates.

Environment
  • Statamic 5.73.22 (also unchanged in 5.74.7, 6.40.0 and master as of 2026-11-07)
  • statamic/ssg 3.1.1, Laravel 10, PHP 8.3
  • Antlers runtime parser ('version' => 'runtime')
Lingua principale
PHP
Stelle
4.9k
Fork
647
Merge medio
21h 3m
PR unite (30g)
128

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di statamic/cms

Tutte le issue di statamic/cms

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.