Field conditions don't work with Entry fields
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 35/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Ferma
- Stack tecnologico
- javascript, laravel, php
- Ambito
- frontend
Direzione di ricerca
Start by reading Validator.js, especially prepareCondition and passesConditions, which the issue identifies as the points where the values are inspected. Use the reproduction steps with an Entry Field set to a maximum of one item, and check how its selected ID is compared with the condition value. The issue is resolved when the matching entry makes the dependent field show as expected.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Bug description
If I want to show or hide another field based on the value of an Entry Field the comparisons don't seem to work.
My hunch is that the comparison is between an integer and an integer as a string.
This could also be a result of using the Eloquent Driver, but I'm not sure.
These tests will fail.
expect(showFieldIf({ string_age: "== 13" })).toBe(true); // Fail
expect(showFieldIf({ age: "=== 13" })).toBe(false); // Pass
expect(showFieldIf({ string_age: "=== 13" })).toBe(true); // Pass ?
expect(showFieldIf({ string_age: "=== 13" })).toBe(true); // Fail
expect(showFieldIf({ string_age: "equals 13" })).toBe(true); // Fail
expect(showFieldIf({ string_age: "equals 13" })).toBe(false); // Pass
What I'm not clear on though is how the right hand value is interpreted.
I feel like the condition is maybe more like 123 === "123"
For example, if I console log from within the Validator.js in prepareCondition I can see that the left hand value is an integer, and the right hand value is a string.
lhs: [0: 25863]
rhs: "25863"
If I console log from passesConditions then I get something like:
field: "archive"
operator: "==="
value: "25863"
I've tried using in, contains, equal, and ===
I ended up writing my own condition and then using ParsIn on the Values coming in, I also added it to the Params but they were already ints.
The Left hand values also seem to be an array of IDs even when choosing a max of 1. So the comparisons could be completely off then.
How to reproduce
Using the Eloquent Driver might make a difference.
Create a fieldset using an Entry Field Max items 1
Create any other Field and then set the condition to show if the Entry Field is equal to t he ID from the entry.
In the editor, select the entry that matches the ID chosen in the condition.
The Field won't show.
Logs
Environment
Environment
Application Name: Tourism Calgary
Laravel Version: 11.45.1
PHP Version: 8.4.7
Composer Version: 2.8.9
Environment: adam
Debug Mode: ENABLED
URL: tourism-calgary.adam.paperleaf.dev
Maintenance Mode: OFF
Timezone: America/Edmonton
Locale: en
Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED
Drivers
Broadcasting: reverb
Cache: redis
Database: mysql
Logs: stack / single
Mail: log
Queue: database
Scout: algolia
Session: redis
Sentry
Enabled: YES
Environment: adam
Laravel SDK Version: 4.15.0
PHP SDK Version: 4.14.0
Release: NOT SET
Sample Rate Errors: 100%
Sample Rate Performance Monitoring: NOT SET
Sample Rate Profiling: NOT SET
Send Default PII: DISABLED
Statamic
Addons: 6
Sites: 1
Stache Watcher: Disabled (auto)
Static Caching: Disabled
Version: 5.57.0 PRO
Statamic Addons
aryehraber/statamic-captcha: 1.14.0
eminos/statamic-tabs: 1.2.0
statamic/collaboration: 1.0.1
statamic/eloquent-driver: 4.25.2
statamic/seo-pro: 6.7.0
thoughtco/statamic-restrict-fields: 1.1.0
Statamic Eloquent Driver
Asset Containers: eloquent
Assets: eloquent
Blueprints: eloquent
Collection Trees: eloquent
Collections: eloquent
Entries: eloquent
Forms: eloquent
Global Sets: eloquent
Global Variables: eloquent
Navigation Trees: eloquent
Navigations: eloquent
Revisions: eloquent
Sites: eloquent
Taxonomies: eloquent
Terms: eloquent
Tokens: eloquent
Installation
Fresh statamic/statamic site via CLI
Additional details
No response
- Lingua principale
- PHP
- Stelle
- 4.9k
- Fork
- 647
- Merge medio
- 1g 7h
- PR unite (30g)
- 103
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di statamic/cms
-
preferences
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
assets
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
statamic/cms#15567 · 1 commento · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
I maintainer di solito rispondono entro 1 giorno
-
accessibility
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
I maintainer di solito rispondono entro 1 giorno
-
antlers
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di statamic/cms
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
I maintainer di solito rispondono entro 1 giorno
-
Do not throw `WordPress.Security.EscapeOutput.OutputNotEscaped` on `apply_shortcodes()`Forse già presa @tbradsha l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
fe: spell out "Auto increment" in the table editor, "AI" reads as artificial intelligence todayAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
landsman/adminer-desktop#120 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
components-web-app/docs#227 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100