mecatui: migrate /reflections proposal browsing to bounded controls

Chiusa
  • Qualcosa non va?
#2,174 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go
Ambito
cli, testing

Direzione di ricerca

Start with cmd/mecatui/ui/reflections.go and inspect the existing bounded controls and their focused tests. Evaluate whether bounded.List and bounded.Viewport fit the proposal list and detail regions, then add scenario-first coverage for cursor reveal, over-scroll and resize, optional actions, safe multiline text, and acting on the correct proposal after refresh. Done means the required behaviors and existing actions and request/response correlation are preserved; run focused UI and bounded tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Scope

Evaluate and migrate the /reflections proposal list and read-only proposal detail in cmd/mecatui/ui/reflections.go as separate bounded browsing regions. The list uses a height-8 cursor-centered window; detail increments detailScroll and only clamps a local value at render time (height-6, minimum four lines). This is distinct from the completed saved-memory browser.

Required outcome

  • Use bounded.List for proposal selection and bounded.Viewport for proposal detail if their measured geometry and interaction boundaries fit; preserve the original list and detail behavior if a concrete region needs its specialized window. Keep titles, footer, range wording, and approval/rejection actions surface-owned. Use presentListRow for standard selected rows.
  • Bound persisted detail offset and physical-row layout so Up after excessive Down/PageDown moves immediately; handle resize, long/multiline proposal evidence, compact heights, and safe untrusted text.
  • Preserve proposal IDs/selection across paging/refresh, action eligibility, and existing request/response correlation.

Verification

Scenario-first tests for cursor reveal with many proposals, long detail with over-scroll and resize, optional action states, safe multiline text, and the correct proposal acted upon after refresh. Run focused UI and bounded tests.

Relates to #1742 and #1589.

Lingua principale
Go
Stelle
299
Fork
28
Merge medio
1g 3h
PR unite (30g)
310

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di stacklok/mecatl

Tutte le issue di stacklok/mecatl

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.