ListenerClass CRD restructure

Aperta

#330 aperta il 21/8/2025 5 commenti 1 reazione 1 assegnatario Vedi su GitHub

@NickLarsenNZ ci sta già lavorando.

Dal 21/8/2025.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

We currently have all ListenerClass spec fields at the top level. Most are passed through to the Service and most are prefixed with service while others are not.

Perhaps we should consider one of these options:

Prefix all fields that will be passed to Service with service.
Move Service related fields down to serviceOverrides
- We need to consider if there are Service fields that should not be overridable.

Option 1 (dismissed)

apiVersion: listeners.stackable.tech/v1alpha1
kind: ListenerClass
metadata:
  name: aws-ec2-nlb-public
spec:
  # 👇 This is not passed to the Service
  preferredAddressType: HostnameConservative
  serviceType: LoadBalancer
  # 👇 prefix with `service`
  serviceLoadBalancerClass: eks.amazonaws.com/nlb
  serviceLoadBalancerAllocateNodePorts: false
  # 👆 
  serviceExternalTrafficPolicy: Local
  serviceAnotations: {}

Option 2 (dismissed)

apiVersion: listeners.stackable.tech/v1alpha1
kind: ListenerClass
metadata:
  name: aws-ec2-nlb-public
spec:
  # 👇 This remains unchanged, not passed to the Service
  preferredAddressType: HostnameConservative
  # 👇 New
  serviceOverrides:
    type: LoadBalancer
    loadBalancerClass: eks.amazonaws.com/nlb
    loadBalancerAllocateNodePorts: false
    externalTrafficPolicy: Local
    annotations: {}

Option 3 (approved)

apiVersion: listeners.stackable.tech/v1alpha1
kind: ListenerClass
metadata:
  name: aws-ec2-nlb-public
spec:
  # 👇 This remains unchanged, not passed to the Service
  preferredAddressType: HostnameConservative
  # 👇 New
  serviceOverrides:
    <service object>
    metadata:
      annotations:
    spec:
      type: LoadBalancer
      loadBalancerClass: eks.amazonaws.com/nlb
      allocateLoadBalancerNodePorts: false
      externalTrafficPolicy: Local

Lingua principale: Python
Stelle: 9
Fork: 2
Merge medio: 1g 9h
PR unite (30g): 8

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

Leggi tutta la issue e poi la guida ai contributi del progetto.
Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
Fai un fork del repository e lavora su un branch.
Apri una pull request che faccia riferimento al numero della issue.