Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Ports Compile: run the assess clean-install check on a PR only when packaging can change

Chiusa
  • Qualcosa non va?
#6,672 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@squid-protocol ci sta già lavorando.

Dal 25/10/2026.

  • #6673 di @squid-protocol — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
github-actions, python
Ambito
ci-cd, testing

Direzione di ricerca

Start with ports-compile.yml and the existing PR file-list handling; read scripts/check_assess_install.py and the listed packaging, assess command, and estate paths to confirm which changes can affect wheel installation. Add a fail-open PR path filter for those changes, while keeping post-merge and nightly runs unconditional. Done when the check is skipped for unrelated PR changes, runs for every listed relevant change, and runs when the file list is unreadable or truncated.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Ports Compile (ports-compile.yml, not a required check) runs scripts/check_assess_install.py (#4726) on every PR it starts. The script builds the wheel, installs it into a fresh venv with no network, and runs the installed gitgalaxy assess on a planted estate and the six burned estates.

Measured 2026-10-25:

  • The step takes ~3.1 min of the ~7.9 min job (median of 60 successful PR runs; 39%).
  • It has not failed once in ~420 completed runs since it landed (2026-10-22). All 7 Ports Compile failures in that window were in "Equivalence ports carry the generator's facades".
  • The post-publish twin, publish-assess-check.yml, runs only after a release is on PyPI, so it is not a per-merge backstop.

What only this step catches is a packaging break: a module or data file the wheel does not ship (packages.find + package-data globs), an entry point, an extra.

Change: on a PR, run the step only when a changed file can cause that:

  • packaging or the check itself: pyproject.toml, MANIFEST.in, the script, the planner, the workflow, the pinned estates;
  • the assess command: gitgalaxy/cli.py, gitgalaxy/tools/readiness/**;
  • any file added, removed, renamed or copied under gitgalaxy/;
  • any non-Python file modified under gitgalaxy/.

Main dispatch (post-merge, cadence) and the nightly always run it, and Main Watch already watches Ports Compile. Fail open: an unreadable or truncated PR file list runs it.

Lingua principale
Python
Stelle
57
Fork
11
Merge medio
1h 17m
PR unite (30g)
980

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di squid-protocol/gitgalaxy

Tutte le issue di squid-protocol/gitgalaxy

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.