Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

DOOM-rosetta: fix the 4 non-PERFECT ports (doomsday + doom-ios .h language, cssdoom + sqldoom function counts)

Chiusa
  • Qualcosa non va?
#5,876 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c, css, javascript, objective-c, postgresql, python, sql
Ambito
testing, tooling

Direzione di ricerca

Start with tests/doom_rosetta/manifest.csv and the golden data in tests/golden_doom_rosetta/; inspect the disputed files and compare the five cssdoom and six sqldoom function-count deltas against ctags. Read CLAUDE.md before deciding which tool is correct, then check the referenced Objective-C work (#5639, #5777, #5795) for the .h rule. Done when each port passes with its expected failure removed, or a documented counting convention justifies retaining the entry.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

claim:nyx lane:nyx

Problem

4 of the 44 DOOM-rosetta ports are not PERFECT. Each one is listed in expected_fails in tests/doom_rosetta/manifest.csv, so the golden passes, but no issue tracks fixing them. Numbers are from the goldens on main (tests/golden_doom_rosetta/).

Port Fails Detail
doomsday language 1 wrong-language file. libs/gui/src/text/fonts_macx.h is labelled objective-c, but the file contains no ObjC syntax (no @interface/@class/@protocol/#import/@end). Separately, the function count is +14.8% vs ctags (25618 vs 22324, 550 files differ); that check still passes, so read it before trusting it.
doom-ios language 5 wrong-language files in the golden, up from 2 on 2026-10-19 (code/iphone/IBGlue.h and code/iphone/iphone_email.h then). Neither of those has ObjC syntax. Check whether the overnight ObjC work (#5639, #5777, #5795) widened the .h → objective-c rule.
cssdoom functions JavaScript and CSS reimplementation: 225 functions vs 215 ctags (+4.7%, over the 3% bar), 5 files differ.
sqldoom functions PostgreSQL and Python: 419 vs 376 ctags (+11.4%), 6 files differ. The SQL work in #5622, #5635 and #5736 probably moved this.

Change

One slice per port, smallest first. Read the disputed files before calling either tool right (CLAUDE.md: agreement is not correctness).

  1. .h language (doomsday, doom-ios): a .h gets objective-c only when it carries ObjC syntax. A macOS- or iPhone-flavoured name or neighbouring .m files alone must not decide it. Add a fixture with our own code, not the port's.
  2. cssdoom functions: list the 5 mismatched files and classify each delta (arrow functions, class methods, object-literal methods, what ctags counts). Fix the engine if it is an engine bug; otherwise record the convention and why.
  3. sqldoom functions: the same for its 6 files (CREATE FUNCTION/PROCEDURE, DO blocks, Python helpers).
  4. For each fixed port, remove its expected_fails entry and re-bless only its golden, with the drift explained in the PR body.

Acceptance

  • All four ports have an empty expected_fails and the golden passes, or a port whose remaining delta is ruled a counting convention keeps its entry with a comment linking that ruling.
  • The six-check PERFECT count is 44/44 (or 44 minus the ruled ports).

Part of #5457. Related: #5619, #5874 (adds the call-graph check).

Lingua principale
Python
Stelle
57
Fork
11
Merge medio
1h 32m
PR unite (30g)
990

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di squid-protocol/gitgalaxy

Tutte le issue di squid-protocol/gitgalaxy

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.