Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

ACP client: umbrella for protocol features Kit does not yet use when driving child harnesses

Aperta
  • Qualcosa non va?
#147 1 commento 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@danielkov ci sta già lavorando.

Dal 13/9/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

enhancement

Tracking issue for Agent Client Protocol features that Kit does not use or handle when it acts as an ACP client, driving child harnesses through subagent, prompt, and fork (src/acp_child.rs, src/tools/subagent.rs). Audited against agent-client-protocol-schema 1.7.0 (fork rev 6e7e044) at Kit v0.1.134 (e75629c). Kit as ACP agent is tracked in #146.

Each item is intended to become its own issue or PR. Check off as they land.

1. Handshake

  • Send clientInfo and negotiate v2. InitializeRequest::new(ProtocolVersion::V1) is sent with default ClientCapabilities and no clientInfo. Read the child's advertised version and use v2 when offered. v2 unlocks group 5.

2. Permissions

  • Flip the permission handler to always allow. permission_outcome answers every session/request_permission with reject_always, reject_once, or cancelled, so a child that gates edits and shell behind permission is effectively read-only. Kit's base posture is unattended execution, so select allow_always when offered, else allow_once. Update docs/user/subagents-and-acp-harnesses.md and docs/user/security-limits-and-troubleshooting.md, which currently document the fail-closed policy. Supersedes the framing in #13.

3. Session setup

  • Send additionalDirectories. Never set on session/new or session/fork. Needed once the parent supports multi-root (#146).
  • Config options beyond model. Only the model select is read and set (session/set_config_option with id model). Pass thought_level and any mode or boolean options from the subagent profile. Consume config_option_update so the handle tracks the child's current state.

4. Prompt content

  • Non-text prompt blocks. Every prompt is a single text block. Support resource_link and embedded resource for file references, and image where the child advertises promptCapabilities.image, so the parent stops pasting file contents as text.

5. v2-only capabilities

  • Steer running children. With v2 negotiated, use session/inject in steer mode to redirect a child mid-turn instead of cancel plus re-prompt.
  • v2 stop reasons and replay. Read state_update idle stop reasons (v2 session/prompt returns {}), and use session/resume with replayFrom: start to rebuild child output after reconnect.

6. Updates consumed

  • Surface dropped session updates. ChildOutput::record keeps message chunks, tool calls, and plan. Dropped: usage_update (no child token or cost accounting), agent_thought_chunk, session_info_update (child titles), available_commands_update, notice, compaction_update, compaction_summary_chunk. Decide which belong in SubagentValue.updates and which feed runlet progress so the TUI shows child activity.
  • Render diff and terminal tool content. Passed through raw today; tool_call_update.content is dropped when it restates rawOutput. Map diff content onto the parent's own diff projection once #146 group 3 lands.

7. Lifecycle

  • Reattach child sessions across Kit restarts. No session/list, session/load, or session/resume calls. Child handles are parent-process-lived even when the child persists sessions. Record child session ids in the transcript and resume them on session load. Overlaps with #12.
  • session/delete cleanup. Explicit branch disposal deletes persistent history when advertised; shutdown preserves it. #186, merged in #197.
  • $/cancel_request before abandoning. session/fork (30s) and session/close (5s) hit fixed deadlines then drop the handle. Send protocol cancellation for the in-flight request first.

8. Auth

  • Child authentication. authMethods in the child's initialize response are never read and authenticate / auth/login is never called. At minimum surface auth_required errors with the methodId so the user can log in out of band. Optionally run terminal auth methods on the user's behalf.

9. Elicitation

  • Handle elicitation/create from children. No handler is registered, so the SDK answers method-not-found and the child's turn fails. Answer decline or cancel at minimum, or route form requests to the parent model as a structured question.

Explicitly out of scope

  • Forwarding mcpServers to children: subagents are separate agents and need not share the parent's tools.
  • Setting the child's permission mode through config options: superseded by group 2.
  • Advertising client fs or terminal capabilities to children: children own their filesystem and shell.

Related: #11, #12, #13, #14, #15 (fork and permission behavior for generic harnesses), #146 (Kit as ACP agent).

Lingua principale
Rust
Stelle
43
Fork
5
Merge medio
5h 43m
PR unite (30g)
81

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di speakeasy-api/kit

Tutte le issue di speakeasy-api/kit

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.