One rejected last_error can still roll back a whole batch (MySQL non-utf8mb4 charset; per-row update fallback)

Aperta
  • Qualcosa non va?
#141 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
kotlin, mysql, postgresql
Ambito
backend, database

Direzione di ricerca

Start with OutboxProcessor.processNext, both store implementations, and 001__create_okapi_outbox_table.sql; compare the batch update transaction behavior with the two proposed options. Decide how row-level failures should preserve the other results, then add the latin1 MySQL test with one healthy entry and one emoji error. Done when the healthy entry remains DELIVERED and the rejected row follows the agreed retry behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Area: okapi-core OutboxProcessor, both stores, MySQL schema · Follow-up to: #130 / #140

Problem

OutboxProcessor.processNext still writes every result of a batch with one updateAfterProcessingBatch call inside the claim transaction. #140 removes the two known values the database rejected in last_error: values over 64 KB on MySQL, and NUL characters on Postgres. But any other rejected value in one row still rolls back the whole batch. Entries that were already delivered go back to PENDING with retries unchanged and are redelivered on every tick.

One more cheap trigger remains on MySQL. 001__create_okapi_outbox_table.sql creates okapi_outbox without an explicit CHARACTER SET, so the table inherits the schema or server default. On a schema that is still latin1 or utf8mb3, which is common on databases from the 5.7 era or migrated ones, a last_error with an emoji or any other character outside that charset fails in strict mode with ERROR 1366 Incorrect string value. The same applies to an HTTP error body or an exception message. The whole batch then rolls back again, delivered entries included. (I haven't reproduced this yet; MySQL 8 defaults to utf8mb4, which is why the tests don't hit it.)

Options

  1. Isolate per-row update failures (covers every cause). If the batch update throws, fall back to updating row by row. A row the database still rejects is written with a sanitized placeholder error, or skipped and left for the next tick with retries advanced, so the other rows' results survive. On Postgres this needs a savepoint per row, because an error aborts the transaction. This changes the store/processor contract, so it needs a design decision.
  2. MySQL charset. Add DEFAULT CHARSET=utf8mb4 for new installs, plus a changeset that converts existing tables (ALTER TABLE okapi_outbox CONVERT TO CHARACTER SET utf8mb4). The conversion rebuilds the table, so the rollout notes need to cover it. A cheaper, narrower option is to convert only last_error.
  3. Sanitize to the column charset. Replace characters the column can't store before writing. This is fragile, because the store would need to know the column charset.

Option 1 fixes the class of problem; option 2 removes the known trigger. I'd do both, starting with option 2 because it is smaller.

Tests

  • MySQL with a latin1 schema: a batch with one healthy entry and one whose error contains an emoji. The healthy entry stays DELIVERED.
  • For option 1: a store that rejects one row of a batch. The rest of the batch keeps its results, and the rejected row's retries advances.
Lingua principale
Kotlin
Stelle
14
Fork
0
Merge medio
9h 54m
PR unite (30g)
11

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di softwaremill/okapi

Tutte le issue di softwaremill/okapi

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.