Missing state updates or optimizable state variables
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 25/100
- Tipo di issue
- Bug
- Chiarezza
- Da chiarire
- Stato di attività
- Ferma
- Stack tecnologico
- solidity
- Ambito
- blockchain
Direzione di ricerca
Start by reading dynamic-nft-3-services/SuperDynamicNFT.sol and ultimate-nft-repo/contracts/RandomIpfsNft.sol. Trace every use and assignment of callbackGasLimit, requestConfirmations, numWords, and s_tokenIdToBreed, then compare their roles with Solidity constant and immutable documentation. Done means each reported variable has a documented decision about whether it needs updates or a modifier change.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Hi, we are a research group on programming languages and software engineering. We recently conducted a systematic study on the causes, effects, and fixes of the inconsistent state update vulnerability in solidity. We are attempting to build a tool to detect bugs about state updates based on our findings. We have tried our prototype tool on some popular Github solidity repositories, and for your repository, we found that there are missing state updates or gas consumption that can be optimized.
The point is that when we declare a state variable in the contract, if the variable is not reassigned throughout the project, it may be a missed state update, including balance, order number, counter, contract status flag, etc. Of course, it may also be a state variable with special purposes that does not need to be changed, such as maximum supply, contract administrator address, configuration information, etc. When declaring these state variables that do not need to be changed, the constant or immutable modifier should be used as required, which will save gas.
For your repository, we found the following state variables that may need attention. If you are not forgetting to update them, perhaps you should declare them with the constant or immutable modifier:
SuperDynamicNFT.sol
State variable: callbackGasLimit, requestConfirmations, numWords
uint32 private callbackGasLimit = 2500000;
uint16 private requestConfirmations = 3;
uint32 private numWords = 6;
RandomIpfsNft.sol
State variable: s_tokenIdToBreed
mapping(uint256 => Breed) private s_tokenIdToBreed;
Do you find our results useful? Your reply and invaluable suggestions would be greatly appreciated, and are vital for improving our tool. Thanks a lot for your time!
(The reason why constant and immutable modifiers can save gas is that they do not consume storage space within the EVM. Their values are compiled directly into smart contract bytecode, which reduces the gas cost of storage. This storage method also avoids the SLOAD operation that reads EVM storage (costs about 100 gas in EVM). The main difference between constant and immutable variables is that the value of immutable variables can be set in the constructor, and immutable variables may cost more gas than constant variables. In addition, there is a slight difference in the variable types they support. The official documentation describes more details: https://docs.soliditylang.org/en/latest/contracts.html)
- Lingua principale
- Solidity
- Stelle
- 243
- Fork
- 116
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di smartcontractkit/smart-contract-examples
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 72/100
smartcontractkit/smart-contract-examples#10 · 1 commento · 1 reazione ·
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 15/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 50/100
smartcontractkit/smart-contract-examples#91 · 1 commento · 1 reazione ·
-
WioowAperta
Difficoltà 5/5 Più di una settimana Idoneità per principianti 1/100
-
Update the Functions example README to use the new .env.encForse di nuovo libera @buddhiraz l’ha presa 956 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 45/100
smartcontractkit/smart-contract-examples#22 · 1 commento ·
Tutte le issue di smartcontractkit/smart-contract-examples
Issue simili
-
performance
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Hamplard-Hub/Hamplard--contracts#706 ·
I maintainer di solito rispondono entro 2 giorni