Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Publish job persists a write credential where core's unpinned scripts can read it

Aperta
  • Qualcosa non va?
#341 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
git, github-actions, typescript
Ambito
ci-cd, release, security

Direzione di ricerca

Leggi .github/workflows/publish.yml, .github/actions/bump-versions-action/action.yml, lib/bump-versions.ts e .github/workflows/bump-versions.yml. Verifica come i checkout di publish e l’action gestiscono le credenziali, quindi esegui i controlli lint e YAML indicati. Il lavoro è completato quando il workflow di publish non espone più credenziali persistenti, mentre l’aggiornamento delle versioni continua ad autenticarsi tramite l’input con ambito limitato dell’action, e il secondo chiamante è stato aggiornato come necessario.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug github_actions up next

Summary

The publish job checks out this repo with credentials persisted, then runs two npm scripts from an unpinned external branch in the same runner. Those scripts can read the checkout's http.extraheader and reuse the job's contents: write token against this repository.

Detail

.github/workflows/publish.yml checks out extension-repo without persist-credentials: false, so extension-repo/.git/config carries an AUTHORIZATION: basic <base64 x-access-token:GITHUB_TOKEN> header. The job grants contents: write.

The same job then checks out paranext/paranext-core with no ref, resolving to whatever its default branch HEAD is at run time, and executes two core-owned scripts before the release is created:

  • npm run stage-dev-packages
  • npm run verify:dev-packages

npm ci --ignore-scripts does not cover these — they are explicit invocations, added deliberately because the install skips lifecycle scripts.

A malicious or compromised core revision could read the sibling checkout's git config, extract the header, and push to this repository.

Why this workflow specifically

Every other workflow already sets persist-credentials: false on its own checkout — test.yml, lint.yml, codeql.yml. publish.yml is the only one that does not, and the only one with contents: write. This is a gap in an otherwise consistent pattern, not a missing convention.

Mitigating factors

  • workflow_dispatch only, so a maintainer has to trigger it.
  • The unpinned core ref is deliberate and documented in-workflow; this issue is about the credential, not the floating ref. Pinning core for release builds only would make release builds diverge from what CI validated.

The two halves are coupled

persist-credentials: false alone breaks the version bump. lib/bump-versions.ts runs git push -u origin HEAD, which authenticates through exactly the header being removed. So the fix has to be:

  1. persist-credentials: false on both extension-repo checkouts in publish.yml — the second one matters too, since clean: false reuses the directory and would otherwise re-persist the credential.
  2. bump-versions-action takes a token input and configures the credential itself, scoped to that one step.

Neither half ships alone.

Upstream consideration

.github/actions/bump-versions-action/action.yml is currently byte-identical to paranext-extension-template. publish.yml has already diverged substantially and is effectively repo-owned, but the action has not.

That means the vulnerability is template-wide — any extension repo built on this template has the same publish-job shape — and a local-only fix to the action creates a conflict surface on every future template merge. Worth deciding whether the action half belongs upstream before patching it here.

Verification already done

A prototype of the above was built and reverted (it was noticed on merge-template, which should stay a clean template merge). Confirmed during that work:

  • Restore-on-exit logic tested under bash: token live during the run; header removed where none pre-existed, restored to the persisted value where one did, and restored on failure.
  • ncipollo/release-action defaults token to ${{ github.token }} and authenticates via the API, not the checkout — the release step is unaffected by dropping persisted credentials.
  • .github/workflows/bump-versions.yml is a second caller of the action; it checks out no external repo so has no exposure, but it would need the new input passed.
  • npm run lint passed; all YAML parsed.

Nothing was run in CI.

Lingua principale
TypeScript
Stelle
2
Fork
0
Merge medio
2g 5h
PR unite (30g)
46

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di sillsdev/interlinearizer-extension

Tutte le issue di sillsdev/interlinearizer-extension

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.