Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[Bug]: exit notification delivery failures are silently swallowed — agent never wakes, no diagnostic

Aperta Adatta ai principianti
  • Qualcosa non va?
#54 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
78/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Tranquilla
Stack tecnologico
typescript
Ambito
cli

Direzione di ricerca

Inizia in src/plugin/pty/notification-manager.ts e ispeziona il catch esterno attorno a promptAsync in sendExitNotification(); l’issue fornisce un errore riproducibile usando un model ID inesistente. Verifica che un errore di promptAsync produca una diagnosi lato plugin, mentre il comportamento esistente dell’exit notification rimane invariato.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

NotificationManager.sendExitNotification() wraps the promptAsync call in a bare catch {} that discards the error. When delivery fails, the <pty_exited> block still shows up in the conversation but no assistant turn is started — the agent appears to simply ignore the notification, and the user has to manually send a message ("continue") to get it to react.

There is no user-visible signal and no plugin-side log, so from the outside this is indistinguishable from "the model decided not to respond". It took a fair amount of digging through the OpenCode server log to find the real cause.

Environment

  • opencode-pty 0.3.6 (current npm latest)
  • OpenCode 1.18.11
  • Linux x86_64, Bun runtime
  • notifyOnExit: true

What happens

  1. Spawn a session with notifyOnExit: true; it exits normally (exit code 0).
  2. The <pty_exited> block appears in the conversation as a user-role message:
<pty_exited>
ID: pty_e1073517
Description: Bootstrap conda base with separate root prefix
Exit Code: 0
TimeoutSeconds: 2400
Timed Out: no
Output Lines: 10
Last Line: Python 3.12.13
</pty_exited>

Use pty_read to check the full output.
  1. No assistant turn follows. The agent stays idle until the user sends something.
  2. Nothing is logged by the plugin. The only trace is in the OpenCode server log:
level=ERROR message="prompt_async failed" sessionID=ses_...
cause="Cause([Die(ProviderModelNotFoundError: Model not found: modelverse/claude-opus-4-7.)])"

63 occurrences of that exact failure in my log.

Root cause in my case

The trigger was my own stale configuration: the top-level model in opencode.json pointed at a model that no longer existed (I had moved those models to a different provider id and forgot to update the default).

Because sendExitNotification() on 0.3.6 omits the model, OpenCode resolves it as input.model ?? agent.model ?? currentModel(sessionID) and ended up on that dangling global default → ProviderModelNotFoundError → the prompt dies → no run.

So the misconfiguration was mine. The bug being reported here is that the failure is completely invisible, which turned a one-line config typo into a confusing "the agent ignores PTY notifications" symptom.

Note on #50

#50 ("fix: preserve model for exit notifications", merged 2026-07-21) addresses exactly this class of model-resolution failure by passing the parent session's model explicitly, and main now has it.

Two things remain, though:

  1. It is not released. The newest npm version / GitHub release is still v0.3.6 (2026-07-05), which predates the merge. Anyone installing via the documented "plugin": ["opencode-pty"] path gets a build without the fix. A patch release would help.
  2. The silent catch is still on main (src/plugin/pty/notification-manager.ts, the outer catch {} around promptAsync). #50 removes one cause of delivery failure, but any other failure — auth, server restart mid-run, session gone, permission, transport — would still be swallowed with no trace.

Suggested fix

At minimum, log it:

} catch (error) {
  console.error(
    `[opencode-pty] failed to deliver exit notification for ${session.id}:`,
    error instanceof Error ? error.message : String(error),
  )
}

Optionally, since a failed delivery means the agent will never be woken, it may be worth surfacing it where the user can actually see it — e.g. including the delivery failure in the next pty_read / pty_list output, so the state isn't silently lost.

The inner catch {} around the model lookup on main looks intentional (documented fallback for older servers) and seems fine to leave as-is.

Repro

Any promptAsync failure reproduces it. The cheapest way:

  1. Set the top-level model in opencode.json to a non-existent id, e.g. "model": "someprovider/does-not-exist".
  2. pty_spawn with notifyOnExit: true running something short, e.g. bash -c "echo hi".
  3. On exit: the <pty_exited> block appears, no assistant turn starts, and the plugin logs nothing.

Thanks for the plugin — the PTY tools themselves have been working well; this was purely an observability gap.

Lingua principale
TypeScript
Stelle
594
Fork
61
Merge medio
13h 20m
PR unite (30g)
2

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di shekohex/opencode-pty

Tutte le issue di shekohex/opencode-pty

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.