fix: a running watcher keeps writing through .codegraph after a pull turns it into a symlink
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
Direzione di ricerca
Start by reading query.IndexDirs and trace how the watcher started by codegraph serve --mcp with auto-sync and codegraph daemon start flushes or swaps the store. Review #374 and #364 for the existing path checks and store swap behavior. Reproduce the checkout replacing .codegraph/store with an external symlink, then confirm the watcher refuses to write through it before each flush or swap.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happens
A running watcher keeps writing index data through .codegraph after a pull or checkout replaces that directory with a symlink.
When a command or daemon.New starts, the root .codegraph and .codegraph/store paths are checked once (#374). A long-running watcher never checks them again. This applies to codegraph serve --mcp with auto-sync and to codegraph daemon start.
.codegraph is ignored by .gitignore because of the * inside it. When a commit adds .codegraph or .codegraph/store as a symlink, Git replaces the real directory without a warning.
The next flush or store swap then follows the new link. Depending on the target, it can:
- rewrite the index of another project,
- replace or delete the contents of another store, or
- create a store at a dangling target outside the repository.
The Git half was observed. The codegraph half is not reproduced. It is a static trace from the security lane of the suite review of #374, rated medium.
Related: #372 (the start-up finding) and #364 (the store swap through a symlinked store directory).
What you expected instead
Before each flush or store swap, the watcher checks the index paths again with query.IndexDirs. If they now resolve outside the repository, the watcher stops with the same refusal error that a command gives.
Another option is to record the resolved paths at watcher start. Before each flush or swap, the watcher compares them with the current resolution and stops on any change.
Steps to reproduce
The Git half was observed with steps 1 to 4. Steps 5 and 6 cover the codegraph half, which is not yet reproduced.
cd <repo>, a repository with a built index in.codegraph.codegraph daemon start- Commit a symlink at
.codegraph/storethat points to a directory outside the repository. git checkout <commit that adds the symlink>- If the checkout replaces the real
.codegraph/storedirectory, edit a source file so the watcher flushes. - Check whether the watcher writes into the symlink target.
Version
Built from source at main (commit d8517c46).
Platform
macOS (Darwin 27.2.0).
How did you install it?
Built from source
Languages in the affected repository
Not applicable.
Before submitting
- I searched existing issues and this is not a duplicate
- I checked the capability matrix and this is not a documented limitation
- This is not a security vulnerability
- Lingua principale
- Go
- Stelle
- 0
- Fork
- 0
- Merge medio
- 7h 42m
- PR unite (30g)
- 111
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di seanb4t/codegraph-go
-
chore needs-triage
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
seanb4t/codegraph-go#380 ·
I maintainer di solito rispondono entro 1 giorno
-
chore needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
seanb4t/codegraph-go#379 ·
I maintainer di solito rispondono entro 1 giorno
-
area:query chore needs-triage spec-needed
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
seanb4t/codegraph-go#377 ·
I maintainer di solito rispondono entro 1 giorno
-
chore needs-triage
Difficoltà 1/5 1-3 ore Idoneità per principianti 84/100
seanb4t/codegraph-go#362 ·
I maintainer di solito rispondono entro 1 giorno
-
area:query bug needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
seanb4t/codegraph-go#355 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di seanb4t/codegraph-go
Issue simili
-
Add iterate GmbH domains to a dedicated list and include it in company and developer categoriesAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
v2fly/domain-list-community#4307 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
I maintainer di solito rispondono entro 1 giorno
-
notify: voice_queue rows are deleted only at startup, so a hub that stays up grows it without boundAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
mattabate/life-distributable#232 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 86/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 83/100
I maintainer di solito rispondono entro 1 giorno