fix: swap and writer lock files differ when one store is opened under two letter cases

Aperta
#365 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go, macos
Ambito
backend, databases

Direzione di ricerca

Start with internal/graphstore/locks.go at lockBesideOnce and internal/graphstore/shared.go at resolveStorePath and sharedKey; compare how lock paths are formed with how the shared-handle table identifies a store. Read the locking changes in #339 and #324, then check the existing lock file tests for the required <store>.swap name. Done when handles opened through different letter cases on a case-insensitive macOS volume share exclusion for both lock files, with the existing lock name preserved.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:indexer bug needs-triage
What happens

Not reproduced yet. This finding comes from reading the code, so the behavior below is derived, not observed.

lockBesideOnce (internal/graphstore/locks.go:47) builds the swap and writer lock path as resolveStorePath(dir) + suffix. resolveStorePath (internal/graphstore/shared.go) runs filepath.Abs and then realpath.Resolve. realpath.Resolve resolves symlinks but does not normalize letter case.

On a case-insensitive file system, which is the macOS default, /x/case/store and /x/CASE/store name one store. The lock paths become /x/case/store.swap and /x/CASE/store.swap. flock takes the lock on the file that the path opens. Whether the two spellings open one inode depends on the file system, so our code does not guarantee that the two handles exclude each other.

The shared-handle table does not have this gap. sharedKey (internal/graphstore/shared.go:119) keys on the device and inode of the resolved parent plus the base name. Commit a5ca60a9 fixed that for #324.

The gap comes from the fix for #339 in commit 990b6499. Related: #339, #324, #286.

What you expected instead

One store has one swap lock and one writer lock, whatever letter case opens it. While the first handle is open, a second open or a ReplaceStore through the other spelling waits or returns ErrStoreLocked.

The fix has a constraint. The lock file must keep the name <store>.swap beside the store, because older releases and existing tests look for it there. An inode-based name is not an option. The fix needs the canonical on-disk spelling of the path, for example F_GETPATH on macOS.

Steps to reproduce

Not run yet. The planned steps, on a case-insensitive volume:

  1. Build the binary from commit 990b6499.
  2. Open a store at /x/case/store with graphstore.Open (internal/graphstore/pebble_store.go:168) and keep the handle open.
  3. From a second process, open the same store through /x/CASE/store.
  4. Check whether the second open waits or returns ErrStoreLocked.
Version

Built from source at commit 990b6499. The output of codegraph version is not captured.

Platform

macOS, Darwin 27.2.0, on the default case-insensitive file system.

How did you install it?

Built from source.

Languages in the affected repository

Not applicable. The bug is in store path handling, not in language extraction.

Before submitting
  • I searched existing issues and this is not a duplicate
  • I checked the capability matrix and this is not a documented limitation
  • This is not a security vulnerability
Lingua principale
Go
Stelle
0
Fork
0
Merge medio
7h 42m
PR unite (30g)
111

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di seanb4t/codegraph-go

Tutte le issue di seanb4t/codegraph-go

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.