[Bug]: Minion with file_client: local crashes on connect: 'AsyncPillar' object has no attribute 'aclose'

Aperta Adatta ai principianti
  • Qualcosa non va?
#70,637 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

@shawnrruss ci sta già lavorando.

Dal 3/11/2026.

  • #70653 di @shawnrruss — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
devops

Direzione di ricerca

Il crash è un AttributeError su aclose() in _post_master_init in salt/minion.py (intorno alla riga 2086), e la stessa chiamata compare nel blocco finally: dell'aggiornamento del pillar (intorno alla riga 4356). Inizia leggendo get_async_pillar() in salt/pillar/init.py per capire quando restituisce AsyncPillar invece di AsyncRemotePillar, quindi confronta i metodi di cleanup delle due classi. Il lavoro è completato quando un minion con file_client: local si connette e risponde a test.ping tramite il master, e il percorso di aggiornamento del pillar viene eseguito senza errori. Esegui i test unitari esistenti di pillar e minion per verificare l'assenza di regressioni.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug needs-triage
What happened?

A minion that connects to a master and has file_client: local set fails on every connection attempt after upgrading to 3008.5. It never becomes available to the master, so salt <minion> test.ping gets no response. salt-call on the same host still works.

Config (in /etc/salt/minion.d/):

master: 127.0.0.1
file_client: local

Log, on every start of the minion:

[CRITICAL] Unexpected error while connecting to 127.0.0.1
Traceback (most recent call last):
  File ".../salt/minion.py", line 1667, in _connect_minion
    await minion.connect_master(failed=failed)
  File ".../salt/minion.py", line 2048, in connect_master
    await self._post_master_init(master)
  File ".../salt/minion.py", line 2086, in _post_master_init
    await async_pillar.aclose()
AttributeError: 'AsyncPillar' object has no attribute 'aclose'
[ERROR   ] Minion unable to successfully connect to a Salt Master.

Cause: salt.pillar.get_async_pillar() returns AsyncPillar when file_client is local, unless use_master_when_local is set. minion.py now calls await async_pillar.aclose() on the returned object, but only AsyncRemotePillar defines aclose(). Minions with file_client: remote are not affected: four of them on 3008.5 work normally on the same master.

There are two call sites in minion.py: _post_master_init (line 2086 in 3008.5, the crash above) and the pillar refresh path (line 4356, in a finally:). I only observed the first, because the minion never got past it.

Versions: from the PyPI sdists, 3008.0 to 3008.2 call async_pillar.destroy() at both sites, and 3008.3 to 3008.5 call aclose(). So this looks like a regression in 3008.3, probably from #70316, which a comment at that call site refers to. The master and 3008.x branches still had both calls and no AsyncPillar.aclose on 2026-11-02. I ran only 3008.5.

Expected: the minion connects as it did on 3008.2.

Fix that worked here: add aclose() to AsyncPillar in salt/pillar/__init__.py, which covers both call sites:

class AsyncPillar(Pillar):
    async def compile_pillar(self, ext=True):
        ret = super().compile_pillar(ext=ext)
        return ret

    async def aclose(self):
        self.destroy()

With this applied and the minion restarted, test.version, saltutil.refresh_pillar wait=True and state.sls ... test=True all succeed through the master, with no errors in the minion log. I have not run Salt's test suite against it.

Type of salt install

Official deb

Major version

3008.x

What supported OS are you seeing the problem on? Can select multiple. (If bug appears on an unsupported OS, please open a GitHub Discussion instead)

ubuntu-24.04

salt --versions-report output
Salt Version:
          Salt: 3008.5

Python Version:
        Python: 3.14.7 (main, Sep 30 2026, 03:35:11) [GCC 11.2.0]

Dependency Versions:
          cffi: 2.0.0
      cherrypy: 18.10.0
  cryptography: 50.0.1
      dateutil: 2.9.0.post0
     docker-py: Not Installed
         gitdb: 4.0.12
     gitpython: 3.2.0
        Jinja2: 3.1.6
       libgit2: Not Installed
  looseversion: 1.3.0
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.2.1
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 24.0
     pycparser: 3.00
      pycrypto: Not Installed
  pycryptodome: 3.23.0
        pygit2: Not Installed
  python-gnupg: 0.5.6
        PyYAML: 6.0.3
         PyZMQ: 27.1.0
        relenv: 0.22.27
         smmap: 5.0.2
       timelib: 0.3.0
       Tornado: 6.5.10
           ZMQ: 4.3.5

Salt Package Information:
  Package Type: onedir

System Versions:
          dist: ubuntu 24.04.5 noble
        locale: utf-8
       machine: x86_64
       release: 6.8.0-147-generic
        system: Linux
       version: Ubuntu 24.04.5 noble
Lingua principale
Python
Stelle
15.8k
Fork
5.6k
Merge medio
5g 9h
PR unite (30g)
99

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di saltstack/salt

Tutte le issue di saltstack/salt

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.