useDisposableMemo disposes native objects in effect cleanup, so a subtree hidden by React <Activity> crashes in release builds when shown again

Aperta
  • Qualcosa non va?
#448 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@mfazekas ci sta già lavorando.

Dal 6/11/2026.

  • #449 di @mfazekas — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react, react-native, typescript
Ambito
backend, mobile

Direzione di ricerca

Start with src/hooks/useDisposableMemo.ts and trace how its effect cleanup disposes the memoized native value. Reproduce the hide and reveal behavior with React <Activity mode="hidden"> in production, then check the existing tests for this hook. Done means revealing the subtree leaves the value usable, with a regression test covering the lifecycle.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

React's <Activity mode="hidden"> runs a component's effect cleanups without unmounting it, and on reveal re-runs the effects with the same memoised values. In production builds useDisposableMemo disposes its value in that effect cleanup. After a hide and reveal the component still holds the disposed HybridObject, and the next call on it dereferences null in native code: release builds skip Nitro's null-NativeState check. Any app that hides a subtree containing a Rive view with <Activity> (React 19.2+) can hit this. We do it for inactive screens and for an animated mascot.

Versions
  • @rive-app/react-native 0.5.5 (RiveRuntime iOS 6.28.1, rive-android 11.12.1). src/hooks/useDisposableMemo.ts on main has the same cleanup.
  • react-native-nitro-modules 0.36.5, React Native 0.88.0, React 19.3.0, Expo SDK 58, new architecture, Hermes.
What we see (production, about 8 days)
iOS Android
Crashes / users 35 / 35 38 / 37
OS iOS 17.6 – 27.0.1 Android 11 – 17
Devices iPhones and iPads moto g35 / g85, Lenovo Tab TB330FU / TB328FU, Samsung A05 / A16 / A52s, vivo, Xiaomi

Each crash is the first call on a view-model instance, or on a property taken from it, after the subtree is shown again. Breadcrumbs show a navigation back to the screen just before.

iOS (EXC_BAD_ACCESS, address 0, JS thread)
hermes::vm::NativeFunction::_nativeCall
margelo::nitro::HybridFunction::createHybridFunction<…>::lambda::operator() (HybridFunction.hpp:119)
margelo::nitro::HybridFunction::callMethod<…> (HybridFunction.hpp:175)

Android (SIGSEGV)
facebook::react::RuntimeScheduler_Modern::executeTask
facebook::jsi::Function::call
margelo::nitro::HybridFunction::createHybridFunction<…>::lambda::operator() (HybridFunction.hpp:119)
margelo::nitro::HybridFunction::callMethod<…> (HybridFunction.hpp:179)
Root cause
useEffect(() => {
  …
  return () => {
    if (__DEV__) { /* deferred with setTimeout(0), cancelled if the effect re-runs */ }
    else {
      cleanupRef.current(ref.current.value);   // disposes now
    }
  };
}, []);
return ref.current.value;                      // the same, now dead, value after the reveal

The __DEV__ branch survives Strict Mode and Fast Refresh because the re-run effect cancels the pending disposal. The production branch has no equivalent, and <Activity> reaches it in production. This is the mechanism of #407 (fixed for useRiveList in #408), but in the shared hook, so it reaches useViewModelInstance and every hook built on it.

Suggested fix

Don't dispose in the effect cleanup. Dispose when the deps change (already done during render), and on a real unmount let the native object go when the JS wrapper is collected. Alternatives:

  • keep the dev-style deferred disposal in production, cancelled when the effect re-runs;
  • mark the value stale in the cleanup so the next render creates a fresh one.

We carry the first option as a local patch (not released yet), with a unit test of the hide-and-reveal case.

Related (cause not confirmed)

After the same hide and reveal, riveViewRef from useRive() is still non-null, but riveViewRef.play / .pause are undefined: "TypeError: undefined is not a function" when an effect that <Activity> re-runs calls them. We saw about 2,450 of these from about 750 users before guarding the calls on our side. It might help to clear the ref, or keep its methods callable, while the view is hidden.

Lingua principale
TypeScript
Stelle
158
Fork
17
Merge medio
4g 4h
PR unite (30g)
23

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di rive-app/rive-nitro-react-native

Tutte le issue di rive-app/rive-nitro-react-native

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.