FM27: staff() returns no name for the human manager

Aperta
  • Qualcosa non va?
#41 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
data, tooling

Direzione di ricerca

Start by reading decode and the code behind staff() and managed_clubs() to understand how personality runs mark positions and how layout values scope decoding. Check the reported FM27 behavior against available tests or save fixtures; the issue notes only one manager and one career were tested. Done means the human manager’s staff() name matches ManagedClub.manager_name on FM27, without changing other staff rows or adding cost for FM26.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

No save files or real data
  • I have not attached or linked a save file, screenshot, or any real player data
What went wrong

On FM27, the human manager's row in staff() has name None, on every save of my career. managed_clubs() on the same save gives the manager's name correctly, and the staff screen shows it.

What you expected

The staff() row with is_human_manager true has the same name as ManagedClub.manager_name.

Suggested fix

decode only tries the positions a personality run marks, and one personality byte of this person can be zero, which falls outside the range of that run. So no run marks this block. For the human manager only, try every position in a short range after the record. Scope it with a layout value, so FM26 and other rows pay nothing.

What I checked, and what remains uncertain
  • It reproduces on main on the first and the last save of the career.
  • A local patch returns the name on all my FM27 saves, and no other staff row changes.
  • I have one human manager to test with, on one career. The personality byte is my explanation for why the marked search misses this block. I have not tested a manager with different values.
Versions
  • fmsave 0.8.0 (main at 418c837), Python 3.13.13, macOS 27.2
  • FM27 build 27.0.0+2486695
Lingua principale
Python
Stelle
28
Fork
8
Merge medio
42m
PR unite (30g)
33

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di rhiever/fmsave

Tutte le issue di rhiever/fmsave

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.