Kubernetes reference chart: no path for BReg migrations that need a --backup binding

Aperta
#2,754 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
helm, kubernetes, python, rust

Direzione di ricerca

Start at deploy/helm/registry-stack/README.md line 385 and the refusal in deploy/stack_operator.py line 49; then read the --backup argument construction in crates/registry-bregctl/src/lib.rs line 846 and deploy/helm/registry-stack/templates/breg-operation-job.yaml. Read tests/test_chart_contract.py and deploy/tests/test_operations.py for the chart/operator contract before choosing option 1 or 2. Done means either a values-driven backup binding rendered as --backup on plan and apply-successor with pass-through and tests, or a short deploy/OPERATIONS.md procedure for staging the file and running the Job by hand.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:breg enhancement

From the review of #2742, the Kubernetes reference chart under deploy/helm/registry-stack/. The chart is an unsupported reference (see its README), so this does not block anything.

What happens

A BReg successor whose plan lists requiredBackups cannot go through the chart:

  • deploy/stack_operator.py refuses the upgrade when the plan lists requiredBackups (around line 49). The refusal is clean.
  • templates/breg-operation-job.yaml builds the bregctl apply arguments with no way to pass --backup BINDING_PATH=BINDING_FILE (crates/registry-bregctl/src/lib.rs, around line 846).
  • The chart README (around line 385) sends the operator to the product procedure, which assumes a host shell. It does not say where the backup binding file is staged on Kubernetes or how the operation Job would read it.

So a destructive BReg migration on the reference deployment has no documented path.

Expected

One of:

  1. A values field for reviewed backup bindings (for example a list of bindingPath and a file in a named, read-only claim or Secret), rendered as --backup arguments on plan and apply-successor, with stack_operator.py passing them through instead of refusing. Tests in tests/test_chart_contract.py and deploy/tests/test_operations.py.
  2. Or, if that is too much for a reference, a short procedure in deploy/OPERATIONS.md: how to stage the binding file, run the operation Job by hand with --backup, and return to the guarded upgrade path.

Option 1 keeps the operator's reconcile-first rule in one place. Option 2 is smaller.

Lingua principale
Rust
Stelle
2
Fork
0
Merge medio
9h 48m
PR unite (30g)
151

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di registrystack/registry-stack

Tutte le issue di registrystack/registry-stack

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.