Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Revert ubuntu-26.04 in fullsend.yaml and disable Renovate github-runner manager

Aperta Adatta ai principianti
  • Qualcosa non va?
#301 2 commenti 1 reazione 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
77/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github-actions, json, yaml
Ambito
ci-cd, devops

Direzione di ricerca

Leggi .github/workflows/fullsend.yaml e .github/renovate.json5, poi confronta i riferimenti ai runner con .github/workflows/prioritize.yml. Ripristina il runner stop-fix a ubuntu-24.04 e disattiva il manager github-runner di Renovate. Il lavoro è completo quando i riferimenti nel workflow generato sono allineati e la configurazione Renovate disattiva quel manager; l’issue richiede anche una verifica nella dashboard e una verifica successiva.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug infra ready-for-triage triaged

What happened

In PR #300, Mend Renovate (hermes-renovate[bot]) opened a dependency update proposing chore(deps): update dependency ubuntu to v26, modifying .github/workflows/fullsend.yaml.

Renovate's built-in github-runner manager detected runs-on: ubuntu-24.04 in the stop-fix job and updated it to runs-on: ubuntu-26.04. However, Renovate did not detect or update the custom workflow input runner_image: ubuntu-24.04 passed to reusable-dispatch.yml under the dispatch job in the same file, nor the matching runner_image: ubuntu-24.04 input in .github/workflows/prioritize.yml. All native ProtoBot CI workflows (ci-workflow.yaml, renovate.yaml) use runs-on: ubuntu-latest.

Because Renovate classified the 24.04 to 26.04 bump as a major version upgrade, platform automerge was disabled per .github/renovate.json5 (matchUpdateTypes: ["patch", "minor"]). Fullsend review was skipped due to the branch filter on renovate/*, and CodeRabbit skipped review because the author was a bot. Maintainer John Strunk silently approved and merged the PR. The modified stop-fix job was never executed or verified during CI because its execution is gated on /fs-fix-stop issue comments.

What could go better

Scaffolded workflow files like .github/workflows/fullsend.yaml and .github/workflows/prioritize.yml are platform-managed artifacts with explicit headers (# This file is managed by fullsend. Do not edit it directly.). Upstream Fullsend manages runner image versions uniformly across shim templates via the __GH_RUNNER__ placeholder.

Allowing Renovate's github-runner manager to update individual runs-on: keys causes two issues:

  1. Version skew within scaffolded workflows: stop-fix was bumped to ubuntu-26.04 while dispatch and prioritize.yml remain on ubuntu-24.04.
  2. Unnecessary human review burden: Because major version upgrades are excluded from automerge, maintainers must manually review and merge standalone runner upgrades that only partially apply to platform shims and are never exercised by the repo's regular CI suite.

Because ProtoBot's native workflows use ubuntu-latest, the github-runner manager only ever touches Fullsend shims. Disabling this manager in .github/renovate.json5 avoids uncoordinated runner updates, leaving runner versioning to Fullsend platform upgrades.

Proposed change

  1. In .github/workflows/fullsend.yaml, revert line 94 runs-on: ubuntu-26.04 back to runs-on: ubuntu-24.04 to restore parity with the dispatch job (runner_image: ubuntu-24.04) and .github/workflows/prioritize.yml (runner_image: ubuntu-24.04).

  2. In .github/renovate.json5, add a configuration rule to disable the github-runner manager:

    {
      "description": "Disable GitHub runner version updates on scaffolded Fullsend workflows",
      "matchManagers": ["github-runner"],
      "enabled": false,
    },

Alternatively, set "github-runner": { "enabled": false } at the root of .github/renovate.json5.

This ensures runner versions in scaffolded shims stay aligned with upstream platform releases rather than ad-hoc Renovate bumps.

Validation criteria

  1. Verify .github/workflows/fullsend.yaml and .github/workflows/prioritize.yml consistently reference ubuntu-24.04 across all jobs and runner inputs.
  2. In the repository Dependency Dashboard (redhat-et/ProtoBot#9), verify that Renovate no longer detects or proposes ubuntu runner updates under github-actions.
  3. Over the next 90 days, verify that no automated PRs are opened modifying runs-on: in .github/workflows/fullsend.yaml.

Generated by retro agent from https://github.com/redhat-et/ProtoBot/pull/300

Lingua principale
Go
Stelle
6
Fork
8
Merge medio
1g 9h
PR unite (30g)
73

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di redhat-et/ProtoBot

Tutte le issue di redhat-et/ProtoBot

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.