Resolve `django_form` limitations
Una pull request collegata è già stata integrata.
- #298 di @Archmonger — integrata
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Da chiarire
- Stato di attività
- Ferma
- Stack tecnologico
- python, react
- Ambito
- full-stack
Direzione di ricerca
Start by reading the client code under src/js/src and the server websocket entry point in src/reactpy_django/websocket/consumer.py, then review the related draft PR #859 and the merged work in #298. Done means the unresolved FileField and ImageField limitations and form restoration on page reload have defined, working behavior.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Current Situation and Proposed Actions
Serializable data fields do not work (Unresolved)
The following fields are currently incompatible with django_form due to ReactPy's client and server not supporting file serialization:
-
FileField -
ImageField
My two initial ideas on how to solve this:
- Extend the current implementation but use a custom messaging schema
- Specifically, adding some sort of messaging websocket schema that can differentiate between layout messages and file transfers.
- On the server-side, we could consider re-using Django's UploadHandler.
- The UploadHandler will probably need to be subclassed to get things working with ReactPy.
- Determine how to pipe the HTTP client/server stack through a websocket
- This would be convenient - specifically would enable us to retain the exact same upload behavior that users would expect on any specific Django version
It might be difficult to figure out what to do on early websocket termination. It might also make sense to create a throttling system where the server can control the incoming upload speed.
There was a related draft PR for file uploads that could be leveraged for inspiration.
Multiple choice fields do not work (Fixed in #298)
There is an additional set of fields that are currently incompatible with django_form, and this seems to be caused by weirdness with how Django re-hydrates/re-renders the form submission data:
-
SplitDateTimeField -
MultiValueField
When the form data is submitted, those fields don't properly rehydrate themselves when given form submission data. This causes incorrect re-renders.
This might just be a limitation of our current rendering methodology. If that is true, then fixing this will require digging into Django's form rendering stack and figuring out why they don't rehydrate properly when given the expected values.
Form restoration on page load (Unresolved)
The following limitation will also need to be resolved:
- Implement form restoration on page reload.
- Perhaps pre-rendering plus the browser's default behavior may already handle form restoration well enough? Probably not, but this should be investigated.
- Maybe this involves creating a new setting called
form_restoration_methodthat can be set to"URL","CLIENT_LOCAL_STORAGE","SERVER_SESSION", orNone. Note that "URL" mode would likely limit the user to one form per page. - Maybe we need to mandate the user provides a
keyfor the form if using form restoration in order to properly re-hydrate the form? Or perhaps we can use the form's CSRF token as the key? Or perhaps it can be linked directly to the browser'sscope["session"]? This needs some additional thought.
- Lingua principale
- Python
- Stelle
- 357
- Fork
- 22
- Merge medio
- 10h 31m
- PR unite (30g)
- 2
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di reactive-python/reactpy-django
-
Add coverage tests Apertacomplexity: 3 (low) priority: 3 (low) type: ci
Difficoltà 3/5 1-2 giorni Idoneità per principianti 45/100
-
complexity: 2 (medium) priority: 3 (low)
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
-
complexity: 2 (medium) priority: 3 (low)
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
-
`pyscript_router` component Apertacomplexity: 1 (high) priority: 2 (moderate)
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
-
complexity: 2 (medium) priority: 2 (moderate) type: investigation
Difficoltà 5/5 Più di una settimana Idoneità per principianti 20/100
Tutte le issue di reactive-python/reactpy-django
Issue simili
-
triage/confirmed
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
agentscope-ai/agentscope#2775 ·
-
comp/desktop P3 type/bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 92/100
NousResearch/hermes-agent#118866 ·
-
bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
apache/cloudstack#14222 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100