Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Remove enableUserSelectHack, set to false by default

Aperta
#709 1 commento 2 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
javascript
Ambito
frontend

Direzione di ricerca

Start with lib/DraggableCore.js around line 97 and lib/utils/domFns.js around line 168 to understand how enableUserSelectHack is defined and consumed. Done means the hack is removed or defaults to false without clearing the user's document selection; verify the Gmail compose reproduction described in the issue.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Rant: We had an incredibly difficult time connecting the dots between a setState causing a modal to hide and figuring out why the user was losing focus in Gmail. I've probably spent 10+ hours digging through our codebase since we have a ton of places where we manage the user's selection. The last thing I expected was for the Draggable wrapper on that modal to be removing all ranges from the document. I had to resort to a binary search "comment half of everything out, see if it still works, repeat" which was still extremely difficult because I didn't consider the very last element to be the one causing issues.

Repro: The user selects text in any Gmail compose window, opens formatting, clicks bold, our modal disappears (from something like document.addEventListener('mousedown', checkIsOutsideAndHideModal), and the user loses their selection and bold is not applied

RCA:
https://github.com/react-grid-layout/react-draggable/blob/master/lib/DraggableCore.js#L97
This comment explains why it exists, but the code that consumes this flag is mostly about removing document ranges
https://github.com/react-grid-layout/react-draggable/blob/master/lib/utils/domFns.js#L168

Lingua principale
JavaScript
Stelle
9.3k
Fork
1k
Merge medio
3g 8h
PR unite (30g)
4

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di react-grid-layout/react-draggable

Tutte le issue di react-grid-layout/react-draggable

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.