A page's `body-classes` replaces the layout classes on `<body>` instead of adding to them

Aperta
#1,218 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@cscheid ci sta già lavorando.

Dal 16/11/2026.

  • #1232 di @cscheid — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
backend

Direzione di ricerca

Start with the body-classes handling in crates/quarto-core/src/template.rs, especially the comments at lines 201 and 1232 cited in the issue. Compare the rendered body classes from the provided q2 repro with the expected Quarto 1 output, then run the repro after the change. Done when page classes are added to computed layout classes while the plain page output remains correct.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

This issue was written by Claude while adding q2 support to Great Docs. The output shown comes from running each repro.

Bug description

When a page sets body-classes, q2 writes only those classes on <body>. The classes q2 computes
for the layout, such as nav-fixed, fullcontent and quarto-light, are dropped. Quarto 1 adds the
page's classes to the computed ones.

This looks intended: crates/quarto-core/src/template.rs:201 says a body-classes "supplied by the
author or a filter is kept wholesale and suppresses the compose below", and so does the comment at
:1232. But the theme's CSS and JavaScript select on those classes: nav-fixed for the fixed
navbar, fullcontent and the other layout classes for the page grid, and quarto-light for the
color scheme. So a page that adds one class of its own loses that styling.

Great Docs sets body-classes on its API and CLI reference pages (doc-reference,
doc-api-page and others), on blog index pages and on the tags index. Its CSS uses them to style
those pages. Under q2 each of those pages loses its layout classes. As a workaround, Great Docs' filter moves body-classes
into a <meta> tag, and a post-render script adds them to the classes q2 wrote.

Steps to reproduce
mkdir body-classes && cd body-classes
printf 'project:\n  type: website\nwebsite:\n  navbar:\n    left: [index.qmd, plain.qmd]\n' > _quarto.yml
printf -- '---\ntitle: Home\ntoc: false\nbody-classes: my-page\n---\n\nHome.\n' > index.qmd
printf -- '---\ntitle: Plain\ntoc: false\n---\n\nPlain.\n' > plain.qmd
q2 render
grep -o '<body[^>]*>' _site/index.html _site/plain.html
Actual behavior
_site/index.html:<body class="my-page">
_site/plain.html:<body class="fullcontent nav-fixed quarto-light">
Expected behavior

As in Quarto 1.9.37:

_site/index.html:<body class="nav-fixed my-page fullcontent quarto-light">
_site/plain.html:<body class="nav-fixed fullcontent quarto-light">

Add the page's body-classes to the computed classes. If replacing them should still be possible,
an explicit opt-in such as !prefer would serve, rather than making replacement the default.

Lingua principale
Rust
Stelle
302
Fork
22
Merge medio
5h 2m
PR unite (30g)
213

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di quarto-dev/q2

Tutte le issue di quarto-dev/q2

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.