Refactor WebAppAdapter::start() and ConsoleAppAdapter::start() into structured runtime pipelines
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
Direzione di ricerca
Inizia da src/App/Adapters/WebAppAdapter.php e src/App/Adapters/ConsoleAppAdapter.php, quindi segui i trait correlati e src/App/BootPipeline.php. Confronta i flussi correnti di start() con RouteDispatcher.php e MiddlewareManager.php per mappare lo stato di runtime e le responsabilità. Il lavoro è completato quando entrambi gli adapter utilizzano pipeline di runtime e oggetti di contesto dedicati, preservando il comportamento web e console indicato; aggiorna i test se necessario.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Refactor WebAppAdapter::start() and ConsoleAppAdapter::start() so runtime execution is no longer handled as flat sequences of loosely connected method calls.
Introduce structured runtime pipelines for web and console flows, similar in spirit to boot stages, so execution becomes explicit, extensible, and ready for future lifecycle hooks.
Why
The constructor already has a clear staged boot flow through BootPipeline, but runtime execution is still handled ad hoc.
In WebAppAdapter::start(), current responsibilities are mixed together in one method:
- preflight handling
- route resolution
- not found handling
- language loading
- debug info logging
- view cache setup
- cached response lookup
- route dispatch
- middleware execution
- response sending
- request cleanup
In ConsoleAppAdapter::start(), runtime execution is also flat:
- core command registration
- app command registration
- command validation
- command execution
This makes both runtime flows harder to reason about and leaves no clean structural boundaries for future lifecycle hooks.
Goal
Create proper runtime execution structures for both web and console adapters before introducing broader lifecycle hooks.
Runtime flow should become stage-based rather than remaining collections of ad hoc method calls.
Proposed Direction
Introduce dedicated runtime pipelines instead of reusing BootPipeline directly.
Suggested runtime structures:
RequestPipelineRequestContextConsolePipelineConsoleContext
These should carry evolving runtime state rather than relying on loose locals and inline control flow.
Suggested Web Runtime Stages
A reasonable first breakdown of the current web flow is:
HandlePreflightStageResolveRouteStageHandleRouteNotFoundStagePrepareRequestStageDispatchRequestStageSendResponseStageCleanupRequestStage
Notes:
PrepareRequestStageshould cover:- language loading
- debug info logging
- view cache setup
DispatchRequestStageshould cover:- cached response lookup
- route dispatch
- middleware execution
Suggested Console Runtime Stages
A reasonable first breakdown of the current console flow is:
RegisterCoreCommandsStageRegisterAppCommandsStageValidateCommandStageRunCommandStage
If needed, command registration can later be collapsed into a single preparation stage, but the first refactor should prioritize clarity.
Scope
This ticket is about refactoring runtime structure for both adapters.
It should not yet define the full lifecycle hook contract. That should come after runtime flow has proper structural boundaries.
Acceptance Criteria
WebAppAdapter::start()is refactored into a structured runtime pipelineConsoleAppAdapter::start()is refactored into a structured runtime pipeline- runtime state is carried through dedicated runtime context objects rather than loose local variables
- web runtime responsibilities such as language loading and view cache handling are preserved in the new structure
- console runtime responsibilities such as command registration, validation, and execution are preserved in the new structure
- the new runtime structures are suitable for later lifecycle hook integration
- tests are updated as needed
Notes
Relevant code:
src/App/Adapters/WebAppAdapter.phpsrc/App/Adapters/ConsoleAppAdapter.phpsrc/App/Traits/WebAppTrait.phpsrc/App/Traits/ConsoleAppTrait.phpsrc/Router/RouteDispatcher.phpsrc/Middleware/MiddlewareManager.phpsrc/App/BootPipeline.php
This ticket should be completed before introducing broader runtime lifecycle hooks.
- Lingua principale
- PHP
- Stelle
- 36
- Fork
- 22
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di quantum-php/framework
-
routing testing
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
quantum-php/framework#547 ·
-
view
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 75/100
quantum-php/framework#542 ·
-
enhancement http
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
quantum-php/framework#565 · 1 commento ·
-
components view
Difficoltà 5/5 Più di una settimana Idoneità per principianti 42/100
quantum-php/framework#551 ·
-
Add explicit @version special route token support for API major versioning within a single module Apertarouting
Difficoltà 5/5 Più di una settimana Idoneità per principianti 45/100
quantum-php/framework#550 ·
Tutte le issue di quantum-php/framework
Issue simili
-
Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
Automattic/safe-publish#594 ·
-
needs-triage Platform(Default)
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
HttpClient
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
symfony/symfony-docs#23092 ·
-
sync-en
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
-
sync-en
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 95/100