Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

`for` loops only accept sets and ranges — not `bit[n]`, arrays, aliases or index expressions

Aperta
  • Qualcosa non va?
#393 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@TheGupta2012 ci sta già lavorando.

Dal 24/8/2026.

  • #406 di @TheGupta2012 — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Tranquilla
Stack tecnologico
python
Ambito
compilers

Direzione di ricerca

Start in Qasm3Visitor._visit_forin_loop at src/pyqasm/visitor.py (around line 2462), where the type check on statement.set_declaration rejects everything except DiscreteSet and RangeDefinition. Move that branch into a helper that returns a list of values, then add the array case first, since it doesn't depend on other work. Done when tests/qasm3/test_loop.py covers each iterable form and an index expression, a write to the loop variable leaves the source array unchanged, and a multi-dimensional array raises ValidationError.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement llm-assisted qasm3 qasm3-coverage

Limitation

For loops states that the iterated <values> may
be any of:

  • a discrete set, e.g. {1, 2, 3}
  • a range expression, e.g. [0:2:10]
  • a value of type bit[n], or the target of a let statement aliasing classical bits
  • a value of type array[<scalar>, n] (one-dimensional)

and adds: "It is valid to use an indexing expression (e.g. my_array[1:3]) to arrive at one of
the types given above."

pyqasm implements only the first two. Any identifier or index expression as the iterable is
rejected.

Example QASM failure

Iterating a bit register:

OPENQASM 3.0;
bit[4] b = "1010";
for bit x in b { }
// ValidationError: Unexpected type <class 'openqasm3.ast.Identifier'> of set_declaration in loop.

Iterating an array:

OPENQASM 3.0;
array[int[8], 3] a = {1, 2, 3};
for int[8] i in a { }
// ValidationError: Unexpected type <class 'openqasm3.ast.Identifier'> of set_declaration in loop.

Iterating an index expression:

OPENQASM 3.0;
array[int[8], 4] a = {1, 2, 3, 4};
for int[8] i in a[1:2] { }
// ValidationError: Unexpected type <class 'openqasm3.ast.IndexExpression'> of set_declaration in loop.

Iterating a classical alias:

OPENQASM 3.0;
bit[4] b;
let c = b;
for bit x in c { }
// ValidationError: Qubit register b not found for aliasing

Change Requested

Extend the loop's iterable resolution to accept, in addition to the existing set and range
forms:

  1. An Identifier naming a bit[n] — loop variable type bit, iterating index 0..n-1.
  2. An Identifier naming a one-dimensional array[<scalar>, n] — loop variable type
    <scalar>, promoted to the declared loop variable type.
  3. An Identifier naming a classical alias.
  4. An IndexExpression that evaluates to any of the above.

Two spec rules to enforce while doing so:

  • Iteration order is guaranteed sequential by index: iden[0], then iden[1], and so on.
  • Assigning to the loop variable inside the body must not modify the underlying array element.

A multi-dimensional array as the iterable must raise a ValidationError — the spec restricts
this to one-dimensional arrays.

Implementation Details

  • The rejection is in Qasm3Visitor._visit_forin_loop at src/pyqasm/visitor.py:2462. It
    branches on the concrete type of statement.set_declaration and falls through for anything
    that is not a DiscreteSet or RangeDefinition.
  • Factor the branch into a helper that returns a plain Python list of values to iterate. That
    isolates the new cases and keeps the unrolling loop below unchanged.
  • Since the loop body is unrolled per value, the "assignment to the loop variable does not
    write back" rule falls out naturally from binding a copy into the loop scope each
    iteration — but add an explicit test, since it is easy to regress with a by-reference bind.
  • Depends on the bit[n] representation work for case 1 and on the classical-alias work for
    case 3; case 2 (arrays) is independent and could land first.
  • Tests: tests/qasm3/test_loop.py — one case per iterable form, an index-expression iterable,
    a write to the loop variable asserting the source array is unchanged, and a
    multi-dimensional array asserting a clean ValidationError.
Lingua principale
Python
Stelle
29
Fork
33
Merge medio
2g 4h
PR unite (30g)
15

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di qBraid/pyqasm

Tutte le issue di qBraid/pyqasm

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.