"ImageEnhance (Color/Contrast/Brightness/Sharpness) .enhance(factor=NaN) silently returns an all-black image"
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
- #10570 di @lazerg — chiusa senza merge
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 1/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Ferma
- Stack tecnologico
- python
Direzione di ricerca
Read PIL/ImageEnhance.py at _Enhance.enhance, where all four enhancement classes share the call to Image.blend. Check the existing enhancement tests for the right place to cover a NaN factor across the classes. Done means the shared implementation rejects NaN while preserving the documented behavior for finite factors; pull request #10570 is already open for this issue.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
enhance() blends the image with its degenerate version using factor;
a NaN factor poisons the blend, and every resulting byte casts back to
uint8 as 0. The result has the exact size and mode of the input - every
downstream check passes - but contains a single value, 0. No exception,
no warning. All four enhancement classes share the behavior (they share the same
base implementation):
import numpy as np
from PIL import Image, ImageEnhance
rs = np.random.RandomState(42)
img = Image.fromarray((np.stack([rs.rand(32, 32), rs.rand(32, 32), rs.rand(32, 32)],
axis=-1) * 255).astype(np.uint8)) # RGB, independent channels
for cls in (ImageEnhance.Color, ImageEnhance.Contrast,
ImageEnhance.Brightness, ImageEnhance.Sharpness):
out = np.asarray(cls(img).enhance(float("nan")))
assert out.shape == (32, 32, 3) and np.all(out == 0)
# uniform 0, unique values = 1, mode/size unchanged;
# cls(img).enhance(1.0) still returns the original image
(An RGB input keeps the test uniform across all four classes. Side note:
on an L-mode input Color is inherently a no-op - its degenerate IS the
image object, and blending an image with itself returns a copy - so the
L-mode Color path is identity for every factor; the other three have
distinct degenerate images in every mode.)
Root cause (verified, Pillow 13.0.0 source)
PIL/ImageEnhance.py:25-39 - the shared base class:
class _Enhance:
def enhance(self, factor: float) -> Image.Image:
...
return Image.blend(self.degenerate, self.image, factor)
factor is passed to Image.blend unchecked; blend computes
im1 * (1 - factor) + im2 * factor per pixel, and with factor = NaN
every byte becomes NaN, casting to uint8 as 0. There is no NaN check at
any layer.
Scope note (why NaN only)
Per #7043, the documented contract is that the enhancement factor has
no range limits - large or negative finite factors are legitimate
and their outputs are the expected clamped/saturated blends (e.g.
factor=float("inf") gives a saturated two-value or all-255 result,
Brightness(-inf) clamps to black - consistent with blending toward an
extreme). NaN is not a factor value at all: it silently collapses the
image to a constant that no choice of finite factor produces on typical
inputs.
Impact
Factors are usually computed (new/old with old=0 producing NaN, or
parsed config values); one NaN silently blanks that image, and the
surrounding batch pipeline "succeeds" - shape, mode, and dtype all look
correct.
Suggested fix
Reject NaN in the shared implementation (covers all four classes at
once), leaving finite factors - of any magnitude or sign - untouched:
# PIL/ImageEnhance.py, _Enhance.enhance
if factor != factor: # NaN check
raise ValueError("factor must not be NaN")
Environment
- Pillow 13.0.0, numpy 2.5.5, Python 3.12.16, macOS arm64 (aarch64)
Prior-art check (2026-11-20)
Related: #7043 (enhancement factor range discussion; maintainers state
factors are intentionally unbounded). No report found for the
NaN-factor all-black output. Re-search "ImageEnhance nan" on submission
day.
- Lingua principale
- Python
- Stelle
- 14k
- Fork
- 2.6k
- Merge medio
- 1g 1h
- PR unite (30g)
- 205
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di python-pillow/Pillow
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
python-pillow/Pillow#10590 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
python-pillow/Pillow#10589 ·
I maintainer di solito rispondono entro 1 giorno
-
Sun raster files with RLE encoding and odd-width rows decode shiftedForse già presa @PerryLink l’ha presa 21 giorni fa. Aperta🤖-assisted
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
python-pillow/Pillow#10370 · 3 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Warn that pre-applying arabic_reshaper + python-bidi corrupts text on a Raqm buildForse già presa @Syamjith-NK l’ha presa 85 giorni fa. ApertaDocumentation Font Rendering PNG Third Party Framework
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
python-pillow/Pillow#9907 · 3 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Example code in ImageText documentation makes incorrect use of get_bbox()Forse già presa @mmporong l’ha presa oggi. ApertaDocumentation
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 25/100
python-pillow/Pillow#10583 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di python-pillow/Pillow
Issue simili
-
[Bug]: DoubleMLData.from_arrays checks the treatment d with force_all_x_finite instead of force_all_d_finiteForse già presa @leninworld l’ha presa oggi. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
DoubleML/doubleml-for-py#471 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
I maintainer di solito rispondono entro 1 giorno
-
BUG: ZarrTrace fails in init_trace for models with datetime coordinates (object dtype coord array)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
I maintainer di solito rispondono entro 2 giorni
-
[Bug] Default key routing (JavaStringHash) picks a different partition than the Java client for about half of keysForse già presa @0z5a l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
apache/pulsar-client-go#1575 ·
I maintainer di solito rispondono entro 2 giorni