Piped v1 Cloud Run plugin panics on deployment and livestate entry points

Aperta
  • Qualcosa non va?
#6,985 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

  • #6986 di @rootp1 — chiusa senza merge

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Tranquilla
Stack tecnologico
go
Ambito
cloud, devops

Direzione di ricerca

Inizia da pkg/app/pipedv1/plugin/cloudrun/deployment/plugin.go e pkg/app/pipedv1/plugin/cloudrun/livestate/plugin.go, quindi esamina la registrazione in pkg/app/pipedv1/plugin/cloudrun/main.go. Esegui il test di ExecuteStage, DetermineVersions, DetermineStrategy e GetLivestate tramite unit test mirati. Il lavoro è completato quando questi entry point non causano più panic, le operazioni non supportate restituiscono errori espliciti e i test di regressione coprono ogni handler.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happened:

The piped v1 Cloud Run plugin exposes deployment and livestate entry points that still call panic("implement me"). Any request that reaches ExecuteStage, DetermineVersions, DetermineStrategy, or GetLivestate will crash the plugin process instead of returning a controlled error.

What you expected to happen:

Cloud Run plugin requests should either complete successfully or return an explicit error without panicking the process.

How to reproduce it:

  1. Open pkg/app/pipedv1/plugin/cloudrun/deployment/plugin.go and pkg/app/pipedv1/plugin/cloudrun/livestate/plugin.go.
  2. Inspect Plugin.ExecuteStage, Plugin.DetermineVersions, Plugin.DetermineStrategy, and Plugin.GetLivestate.
  3. Invoke any of those exported methods from a focused unit test or a small harness.
  4. Observe that the current implementation panics immediately because each method ends in panic("implement me").

Environment:

  • piped version: repository checkout on 2026-07-07
  • control-plane version: repository checkout on 2026-07-07
  • Others: reproduced from current master checkout by static inspection of the exported Cloud Run plugin handlers

Summary

The v1 Cloud Run plugin binary is registered with both deployment and livestate handlers, but several required methods are still stubbed with panics.

Affected Area

pkg/app/pipedv1/plugin/cloudrun

Steps to Reproduce

  1. Build or inspect the Cloud Run v1 plugin module.
  2. Call ExecuteStage, DetermineVersions, or DetermineStrategy on deployment.Plugin.
  3. Call GetLivestate on livestate.Plugin.
  4. Observe process termination from panic("implement me") instead of an error response.

Expected Behaviour

Cloud Run plugin handlers should never crash the plugin process. Unsupported behavior should be reported through explicit errors until full implementations exist.

Actual Behaviour

The exported handlers panic immediately, which can terminate the plugin process when those code paths are exercised.

Technical Evidence

  • pkg/app/pipedv1/plugin/cloudrun/deployment/plugin.go:51-63
  • pkg/app/pipedv1/plugin/cloudrun/livestate/plugin.go:27-29
  • pkg/app/pipedv1/plugin/cloudrun/main.go registers both deployment and livestate plugins through sdk.NewPlugin(...), so these panic paths are part of the published plugin surface.

Suspected Root Cause

The Cloud Run v1 plugin skeleton was merged before deployment and livestate handler implementations were completed.

Proposed Direction

Replace the panic stubs with explicit returned errors for unsupported operations, or gate registration of unfinished handlers until complete implementations are ready. Add regression tests covering each handler so future changes cannot reintroduce process panics.

Acceptance Criteria

  • Cloud Run plugin deployment and livestate entry points no longer panic.
  • Unsupported operations return explicit errors instead.
  • Focused unit tests cover ExecuteStage, DetermineVersions, DetermineStrategy, and GetLivestate.
Lingua principale
Go
Stelle
1.4k
Fork
391
Merge medio
4g 1h
PR unite (30g)
58

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di pipe-cd/pipecd

Tutte le issue di pipe-cd/pipecd

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.