Documenting/improving ways to quickly check docbook xml syntax/correctness on editor save
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 46/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Tranquilla
- Stack tecnologico
- php, vim, xml
- Ambito
- documentation, tooling
Direzione di ricerca
Inizia esaminando doc-base/scripts e xmllint.php e la configurazione di Vim proposti nell’issue. Prova la validazione su un singolo file XML e confrontala con il comando esistente phd --docbook. Il lavoro è completato quando viene documentato e fornito un percorso pratico per la validazione al salvataggio nell’editor, rendendo chiara la gestione prevista delle entità e degli errori XML.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Motivation
Rendering a part of the docbook takes around 10 seconds for me, even for a partial build, and requires prerequisite steps
time phd --docbook doc-base/.manual.xml --package PHP --partial en/reference/simdjson --format xhtml
Some editors (e.g. vim) don't have xml validation built in, and rely on plugins using external programs such as xmllint (from libxml2-utils) to work, so documenting ways to set up xml validation would save time
Related to https://github.com/php/doc-en/issues/1148
Feature Request
Add example scripts and editorconfigs to quickly check validity of individual xml files to doc-base/scripts.
This could possibly be extended by hardcoding known entities and warning about unknown entities, xml tag names, etc
(or by actually configuring the proper dtd files when run in the doc-base folder)
(other alternatives exist, but usually require external programs, e.g. https://github.com/vim-syntastic/syntastic/blob/master/syntax_checkers/xml/xmllint.vim - assume php documentation contributors would have php installed)
" Example additions to vimrc to check xml tags match up
function! XMLsynCHK()
let winnum =winnr() " get current window number
silent make %
cw 4 " open the error window if it contains error
" return to the window with cursor set on the line of the first error (if any)
execute winnum . "wincmd w"
:redraw!
endfunction
au! BufWritePost *.xml call XMLsynCHK()
au FileType xml,docbk setlocal makeprg=/path/to/doc-base/scripts/xmllint.php
au FileType xml,docbk setlocal errorformat=%m\ in\ %f\ on\ line\ %l
#!/usr/bin/env php
<?php // xmllint.php
/** @return never */
function print_usage_and_exit() {
global $argv;
fprintf(STDERR, "Usage: %s path/to/file.xml\n", $argv[0]);
exit(1);
}
call_user_func(function () {
error_reporting(E_ALL);
ini_set('display_errors', E_ALL);
global $argv;
if (count($argv) !== 2) {
print_usage_and_exit();
}
$file = $argv[1];
if (!is_readable($file)) {
fprintf(STDERR, "%s is not readable\n", var_export($file, true));
print_usage_and_exit();
}
$contents = file_get_contents($file);
if (!is_string($contents)) {
fprintf(STDERR, "Could not read %s\n", var_export($file, true));
print_usage_and_exit();
}
libxml_use_internal_errors(true);
try {
(new DOMDocument())->loadXML($contents, LIBXML_PARSEHUGE|LIBXML_COMPACT);
} catch (Exception $e) { }
foreach (libxml_get_errors() as $error) {
$message = trim($error->message);
if (preg_match('/^Entity.*not defined$/', $message)) {
continue;
}
printf("%s in %s on line %d\n", $message, $file, $error->line);
}
});
Brainstorming other ideas
- For DOMDocument::schemaValidate - I see https://docbook.org/ns/docbook has no official schema. doc-base has RFC/schema for a proposed schema but the commit from 2010 notes "PhD doesn't use any of this"
- I'm not familiar with the implementation of the tools. Currently, it seems like we have to generate the entire .manual.xml with the manual of all settings, to generate the html even for one page. (process on http:// site for http://doc.php.net/tutorial/local-setup.php )
- I haven't yet looked into whether phd or configure.php can be changed to run on an error-tolerant way on a single file without building the full manual.xml file with every single page (or by using some other method faster for decoding and retrieval than parsing an entire xml file, e.g. putting all the definitions once in sqlite, caching it, and only querying the necessary rows later and on manual request)
- Lingua principale
- PHP
- Stelle
- 371
- Fork
- 131
- Merge medio
- 3g 18h
- PR unite (30g)
- 6
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di php/doc-base
-
Manual infra-estructure Aperta
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
Tutte le issue di php/doc-base
Issue simili
-
Solved site promotion gate fails on runner PHP patch drift (expects 8.2.33, runner installs 8.2.34) Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Automattic/blocks-engine#2161 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
Automattic/static-site-importer#1824 ·
-
[Chore] Keep one viget-block-generator skill and replicate it, instead of four tracked copies Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
Cannot reset column width Aperta0. Needs triage bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
0. Needs triage 35-feedback bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100