Launcher test suite: trusted build identity for executables it runs, and run the suite in CI

Aperta
#255 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp, github-actions

Direzione di ricerca

Read the launcher test suite and run_launcher_tests.py, then trace how testing builds are identified and how CI builds and runs the launcher tests. The issue names the guarded launch paths and integration checks to cover, but the trusted identity mechanism and CI changes span multiple components. Done means changed or mixed executables are refused on every guarded path and the default stand-in payload suite cases run in CI with failures failing the job.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

The launcher test suite only runs programs it can identify as testing builds, and it refuses non-testing programs before they start (PR #253). Two hardening steps were deliberately left out of 0.6.5 and are tracked here.

1. Trusted build identity for executables the suite runs

Today a program counts as a testing build when it carries the testing-only named resource, the testing hook strings inside its sections, and a matching PE checksum. That rejects release builds, modified copies and the runnable canaries. It is not a provenance proof: the PE checksum is unkeyed, so a binary crafted on purpose could carry the same resource, strings and a recomputed checksum.

Proposal: have the testing build write an identity the suite can verify independently of the file itself, such as a build manifest with the full SHA-256 of each executable produced in that build (launcher, restorer, uninstaller, canaries), checked before every launch, or a keyed marker. Mixed or changed images should fail. Add a negative control with a runnable canary that carries the resource, the strings and a valid recomputed checksum, and show that it is refused on every guarded launch path.

2. Run the launcher suite in CI

CI builds the testing launcher and runs the core tests, but it does not run run_launcher_tests.py. The suite's integration checks can regress while CI stays green: the runnable-canary refusals on each entry point, the inherited-override stripping, the helper-permission negative control, and the edition/junction temp-folder checks.

Proposal: run the default launcher-suite cases on the stand-in payload in CI, including both launcher entry points (--launcher and --no-direct-launcher) and the helper and temp integration checks, with failures failing the job.

Lingua principale
C++
Stelle
12
Fork
2
Merge medio
3h 10m
PR unite (30g)
171

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di phantoslayer21/wronggpu

Tutte le issue di phantoslayer21/wronggpu

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.