Map: Sign in with Apple, native on iOS

Aperta
#465 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
ios, supabase, terraform, typescript

Direzione di ricerca

Start with the listed authentication and account deletion docs, production configuration, mobile app README, and the linked entry points: libs/api-server/src/http/account-auth.ts, terraform/production/supabase.tf, ADR 0019, and apps/mobile-app/AGENTS.md. Revalidate the linked Apple research and specify the unresolved login UI, secret rotation, Private Email Relay, notifications, fresh authentication, release signing, testing, and documentation work. Done means the acceptance criteria in the issue are met, including native iOS sign-in, web sign-in, the Android decision, token revocation, relay email delivery, and updated docs.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

wayfinder:map

Destination

A spec ready for /to-tickets that adds Sign in with Apple to Cup: the native Apple sheet on iOS, Supabase's OAuth flow on the web, a decided and specified answer for Android, the Worker admitting Apple identities, the login UI, custody of Apple's refresh token and its revocation on account deletion, the Private Email Relay, release signing of the iOS app and its Share Extension, and the docs. Its acceptance check is CUP-45's acceptance criteria: release-signed builds of the iOS app and its Share Extension can be produced; on a physical iPhone, Sign in with Apple uses the native sheet and ends in a Supabase session in secure storage; on the web, Sign in with Apple creates and signs into a Cup account; the Android decision is implemented; deleting an account that signed in with Apple revokes its Apple tokens; email to a Hide My Email address arrives; the authentication and production configuration docs describe Apple sign-in.

Notes

  • Origin: CUP-45 Enroll in the Apple Developer Program and add Sign in with Apple, native on iOS (Linear). It blocks CUP-44 and CUP-79.
  • The map plans only and carries no build. Apple Developer console work with lead time (team, enrollment, identifiers, key) is charted as wayfinder:task tickets so later decisions can rely on real identifiers; provisioning profiles and release signing in Xcode belong to the spec.
  • Settled while charting (2026-11-18).
    • iOS MUST use the native ASAuthorizationAppleIDProvider sheet through a Capacitor plugin, bound to a nonce, exchanging the identity token with Supabase via signInWithIdToken, as Android does for Google. A web flow in the WebView or a browser sheet is not acceptable for Apple on iOS.
    • Same person through Google and Apple is decided in this map; already-created accounts are never merged.
    • Today's Apple access is a team-member seat on Verena Handler-Kunze's individual membership. Apple's user identifier is team-scoped, so the developer team is decided before any real user signs in with Apple.
  • Starting point: the Worker admits only Google identities and the local test account (account-auth.ts); deletion revokes only Google tokens (account deletion); Supabase Terraform enables only Google (supabase.tf); iOS signs in with Google through a browser sheet (ADR 0019); the Xcode project keeps the team ID out of tracked files (apps/mobile-app/AGENTS.md).
  • Prior research, whose Apple findings need revalidating: deferred Apple/iOS handoff, native provider research, account deletion research.
  • Skills: grilling and domain-modeling for grilling tickets, research for research tickets. Read the glossary, authentication, account deletion, production configuration and apps/mobile-app/README.md first.

Decisions so far

Not yet specified

  • Login UI. Button order, styling and copy per platform under Apple's button guidelines, and where Apple appears next to Google.
  • Client secret rotation. Who rotates Supabase's Apple client secret (a JWT valid at most six months), how, and how an expiry is noticed.
  • Private Email Relay. Registering Cup's Resend sender domain and checking that mail, including account deletion notices, reaches a Hide My Email address.
  • Server-to-server notifications. Whether and how Cup handles Apple's account-deleted, consent-revoked and email-change events.
  • Fresh authentication with Apple. How deletion and recovery confirmation count a fresh Apple sign-in, on each platform.
  • Release signing. Provisioning profiles and certificates for the app and its Share Extension, kept out of tracked files, and the build command that produces a release-signed build.
  • Testing. An Apple identity in the fake auth provider, mobile E2E coverage of the native sheet's handoff, and the physical-device check.
  • Documentation. Which ADRs, architecture pages, glossary terms and READMEs change.

Out of scope

  • Distribution: TestFlight, App Store Connect records and uploads stay in CUP-79.
  • Native Google sign-in on iOS: CUP-63; Google on iOS stays on ADR 0019.
  • Merging already-created accounts.
Lingua principale
TypeScript
Stelle
1
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di patricktree/cup

Tutte le issue di patricktree/cup

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.