[BUG] Deleted/renamed remote folder stays in file list forever – parent folder sync doesn't remove stale entries (oCIS, 404 loop)

Aperta
#5,014 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
android, kotlin
Ambito
data, mobile

Direzione di ricerca

Start with the log lines: ReadRemoteFolderOperation.kt:101 logs that a synced subfolder's local file is missing, and SynchronizeFileUseCase.kt:56 returns FileNotFound as a Success. Trace how OCFileRepository.readFile and the folder sync path decide whether to delete local entries. Done means that after a parent folder sync, a folder missing from the server response and its children are removed locally, and a 404 on a stale file or folder removes it and returns to the parent.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Type:bug
Actual behaviour
  • A folder that was deleted or renamed on the server still shows up in the app, together with its files, even after the parent folder is refreshed.
  • The parent folder syncs fine (207), and the server no longer lists the folder in its response. The app keeps the stale entries anyway.
  • Opening the stale folder or tapping one of its files gets a 404 Not Found every time. The app logs a FileNotFoundException but never removes the local entries.
  • When a stale file is tapped, the sync use case returns FileNotFound as a Success result, and the UI only says "File must be downloaded before opening it".
  • "Open in Collabora" still works for these stale files. The file opens and can be edited in Collabora. This suggests the file still exists on the server under its file ID (moved/renamed rather than deleted), and only the app's path-based requests (/Parent/Subfolder/...) fail with 404.
  • The user is stuck with "ghost" items that can't be opened, downloaded, synced or cleaned up.
Expected behaviour
  • When the parent folder (/Parent/) syncs and the server no longer lists Subfolder/, the app removes Subfolder/ and all its children from the local database.
  • At the latest, a 404 on PROPFIND of a folder or file should mark the local entries as deleted, remove them from the list, and send the user back to the parent folder.
Steps to reproduce
  1. Set the folder as "available offline"
  2. In the app, browse and sync a folder that contains files (e.g. /Parent/Subfolder/ with document-1.pdf and document-2.pdf).
  3. Delete or rename Subfolder on the server (web UI or another client).
  4. In the app, open /Parent/ and pull to refresh. Subfolder is still listed. Open it, or tap one of its files. You get a 404 error every time and the entries are never removed.

Can this problem be reproduced with the official owncloud server?
(url: https://ocis.ocis.master.owncloud.works, user: einstein, password: relativity)

  • not tested yet
Environment data

Android version: 16.1.134

Device model: Nothing Phone (3a) Pro

ownCloud app version: 4.8.4 (build 8fd9e360a)

ownCloud server version: ownCloud Infinite Scale 8.2.1

Logs
Web server error log

Not applicable. The server behaves correctly: the folder is missing from the parent PROPFIND response, and direct requests return a proper 404:

PROPFIND https://<server>/dav/spaces/<space-id>/Parent/ → 207 (Subfolder not listed)
PROPFIND https://<server>/dav/spaces/<space-id>/Parent/Subfolder/ → 404 Sabre\DAV\Exception\NotFound
PROPFIND https://<server>/dav/spaces/<space-id>/Parent/Subfolder/document-1.pdf → 404 Sabre\DAV\Exception\NotFound
PROPFIND https://<server>/dav/spaces/<space-id>/Parent/Subfolder/document-2.pdf → 404 Sabre\DAV\Exception\NotFound
ownCloud log (data/owncloud.log)

Android app log (excerpt):

I: ReadRemoteFolderOperation.kt:97 Synchronized /Parent/ with 9 files. - HTTP status code: 207

W: ReadRemoteFolderOperation.kt:101 Synchronized /Parent/Subfolder/ Local file does not exist
D: ViewModelExt.kt:69 Use case executed: SynchronizeFolderUseCase with result: Error(throwable=com.owncloud.android.domain.exceptions.FileNotFoundException)

I: ReadRemoteFileOperation.kt:75 Read remote file /Parent/Subfolder/document-1.pdf with status 404
I: SynchronizeFileUseCase.kt:56 File does not exist anymore in remote
com.owncloud.android.domain.exceptions.FileNotFoundException
at com.owncloud.android.data.RemoteOperationHandlerKt.handleRemoteOperationResult(RemoteOperationHandler.kt:110)
at com.owncloud.android.data.RemoteOperationHandlerKt.executeRemoteOperation(RemoteOperationHandler.kt:85)
at com.owncloud.android.data.files.datasources.implementation.OCRemoteFileDataSource.readFile(OCRemoteFileDataSource.kt:158)
at com.owncloud.android.data.files.repository.OCFileRepository.readFile(OCFileRepository.kt:334)
at com.owncloud.android.usecases.synchronization.SynchronizeFileUseCase.run(SynchronizeFileUseCase.kt:50)
at com.owncloud.android.usecases.synchronization.SynchronizeFileUseCase.run(SynchronizeFileUseCase.kt:36)
at com.owncloud.android.domain.BaseUseCaseWithResult.invoke(BaseUseCaseWithResult.kt:30)
at com.owncloud.android.extensions.ViewModelExt$runUseCaseWithResult$1.invokeSuspend(ViewModelExt.kt:67)
D: ViewModelExt.kt:69 Use case executed: SynchronizeFileUseCase with result: Success(data=...SynchronizeFileUseCase$SyncType$FileNotFound@f2308a9)
D: FileDetailsFragment.kt:429 /Parent/Subfolder/document-1.pdf : File must be downloaded before opening it

I: ReadRemoteFileOperation.kt:75 Read remote file /Parent/Subfolder/document-2.pdf with status 404
I: SynchronizeFileUseCase.kt:56 File does not exist anymore in remote
D: FileDetailsFragment.kt:429 /Parent/Subfolder/document-2.pdf : File must be downloaded before opening it
Lingua principale
Kotlin
Stelle
4.2k
Fork
3.1k
Merge medio
3g 9h
PR unite (30g)
16

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di owncloud/android

Tutte le issue di owncloud/android

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.