Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Relay rejects host names, so a changing iMotions IP can't be entered as a name

Aperta
  • Qualcosa non va?
#240 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

@PRINCEKK122 ci sta già lavorando.

Dal 18/10/2026.

  • #242 di @PRINCEKK122 — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
networking

Direzione di ricerca

Start with State::validate_tcp_addr in relay/src/state.rs and check how its result is used when connecting; the issue proposes resolving host:port with ToSocketAddrs. Confirm the client's network need first, since the issue says it is unverified and asks for triage. Done means host names and IPs are accepted, while unresolved names and missing or out-of-range ports produce clear errors.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:relay enhancement needs-triage rust

Is your feature request related to a problem? Please describe.
State::validate_tcp_addr (relay/src/state.rs) parses the address as a SocketAddr, so only a literal IP and port are accepted. localhost:9999 and a machine name such as IMOTIONS-PC:<port> are rejected. The README documents this ("localhost:9999 is rejected"), but it may be a problem in the client's lab. Her simulator and iMotions run on different machines (the plugin runs on the simulator machine, iMotions on its own computer), so the relay needs the iMotions computer's network address. If that address comes from DHCP it can change between sessions, and the saved-address dropdown would then hold a stale entry.

Describe the solution you'd like
Accept host:port where host is a name or an IP, resolving it at connect time (ToSocketAddrs), and keep a clear error for a name that does not resolve or a port that is missing or out of range.

Describe alternatives you've considered
Keep literal IPs only and ask the lab to give the iMotions machine a fixed IP. That costs nothing in code but needs the lab's IT. It is worth asking the client before building this.

Additional context
Not confirmed as a real need: we don't know how the lab's network is set up, so this is needs-triage until the client answers whether the iMotions machine has a fixed IP. Related: #195 (which port iMotions listens on) and #139 (saved addresses, closed).

Lingua principale
Rust
Stelle
4
Fork
9
Merge medio
5g 7h
PR unite (30g)
11

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di oss-slu/PilotDataSynchronization

Tutte le issue di oss-slu/PilotDataSynchronization

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.