Unintuitive navigation in Problem Editor if a .tmp version exists

Aperta
#2,782 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
perl
Ambito
full-stack

Direzione di ricerca

Reproduce it in the Problem Editor: open an existing .pg file, edit it without saving, then reopen the same file and note that the .tmp copy loads instead. Also try choosing a sample problem after a .tmp exists. The issue proposes two fixes (block edits to sample and blank problems until saved under a new name, or ask the user to choose between the .tmp and original on load) but does not pick one, so agree on the behaviour with maintainers first. Done when the chosen behaviour is implemented and covered by a test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

If there is a .tmp version of a .pg file, then the Problem Editor always loads that instead of the actual file that the user requested. I run into two issues with this:

  1. If I'm editing a .pg file I often miss the message at the top telling me that there are unsaved changes, and end up building new changes on top of experimental stuff that I never intended to keep.
  2. In 2.20 when you click on the Problem Editor you are asked to choose between a new problem template, an existing file, or a sample problem. If I choose the first or third option then I expect to get what I asked for (i.e. a blank problem or a sample problem), but if there is a .tmp version, then I'm not actually getting a sample problem. Instead I'm getting my previous edits of the sample problem. There is still the message at the top about unsaved changes, but it isn't what I asked for.

I'm not sure how to make this more intuitive.

For the second issue one option is to not allow edits of sample problems and blank problems until a copy with a new name has been saved, which would mean that there would never be a .tmp version for the Problem Editor to find. This would guarantee that you always get the true blank/sample problem that you asked for.

A different approach is to make the user decide whether to use the edited version or the original as soon as the problem is loaded into the editor. i.e. if a .tmp version of the requested file exists, then send the user to a screen that says "There are unsaved changes to this problem file", and then makes them explicitly choose whether to revert the changes and edit the original, or continue from the unsaved changes.

Lingua principale
Perl
Stelle
164
Fork
167
Merge medio
6g 7h
PR unite (30g)
27

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di openwebwork/webwork2

Tutte le issue di openwebwork/webwork2

Issue simili

Altre issue su Perl

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.