Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Follow up on NetworkPolicy review nits from PR #2494

Aperta
  • Qualcosa non va?
#2,495 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@kaovilai ci sta già lavorando.

Dal 16/10/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

Summary

Track the actionable unresolved inline review nits from PR #2494, which scopes operand NetworkPolicies and fixes DNS egress.

Requested by @kaovilai in https://github.com/openshift/oadp-operator/pull/2494#issuecomment-6223577628.
Source PR: https://github.com/openshift/oadp-operator/pull/2494.

Required changes

1. Report unexpected mover pod watch closure

Affected area: tests/e2e/networkpolicy_movers_test.go, in the goroutine that consumes events.ResultChan().

The review identifies a silent exit when the watch channel closes. If the API server closes the watch during a backup or restore, later mover pods are not observed. Verification can then report a missing mover pod instead of the watch failure.

Set watchErr when the channel closes while the context remains active, unless an error is already recorded. Protect shared state with the existing mutex. Do not report normal context cancellation and cleanup as failures. A retrying watch or informer is an optional resilience improvement, not a prerequisite for this diagnostic fix.

Review references:

Acceptance criteria:

  • Unexpected channel closure produces a specific watch-closure diagnostic.
  • Normal cancellation and cleanup do not produce a watch error.
  • An existing watch error is preserved.
  • Focused tests cover unexpected closure, normal cancellation, and existing-error preservation.
2. Document the legacy default-deny stale-owner migration edge case

Affected areas: docs/network_policies.md and the behavior of deleteLegacyDefaultDenyNetworkPolicy in internal/controller/networkpolicy.go.

The review identifies an edge case during rapid DPA deletion and recreation in the same namespace. The replacement DPA has a different UID. If garbage collection has not yet removed the old DPA's legacy default-deny policy, metav1.IsControlledBy does not identify that policy as controlled by the replacement DPA. Reconciliation preserves the policy, which can continue namespace-wide isolation until garbage collection removes it.

Document this migration limitation, its effect on partner controllers, and safe troubleshooting guidance for delayed garbage collection. Preserve the current ownership safeguards. Any proposal to delete policies controlled by a different DPA UID requires a separate safety evaluation.

Review reference:

Acceptance criteria:

  • The migration documentation describes the rapid delete/recreate scenario and UID mismatch.
  • The documentation explains that the legacy policy can continue isolating unrelated pods until garbage collection completes.
  • Troubleshooting guidance requires checking policy ownership and DPA state before manual intervention.
  • The follow-up does not weaken ownership checks or UID/resource-version deletion preconditions.

Scope

The two mover-watch review threads describe one work item. The inline comment that confirms empty-ingress behavior does not require a change. This issue tracks the actionable inline nits; it does not reclassify or resolve the separate automated pre-merge check findings.

Lingua principale
Go
Stelle
93
Fork
93
Merge medio
1g 20h
PR unite (30g)
27

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di openshift/oadp-operator

Tutte le issue di openshift/oadp-operator

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.