refactor: extract Monaco setup and completion providers from QueryEditor

Aperta
  • Qualcosa non va?
#5 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Tranquilla
Stack tecnologico
react, typescript
Ambito
desktop, developer-experience

Direzione di ricerca

Start with src/components/editor/QueryEditor.tsx and locate the Monaco setup, JOIN and schema completion providers, intention actions, and live-template expansion. Read the existing editor lifecycle and useLiveTemplates usage before deciding how their dependencies are registered and disposed. The requested files are monacoSetup.ts, sqlCompletionProvider.ts, intentionActions.ts, and liveTemplateProvider.ts alongside the component. Done means the component is under roughly 600 lines, the listed features still work, checks pass, and a Vitest test covers pure live-template expansion.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

good first issue help wanted refactor

src/components/editor/QueryEditor.tsx is 1,179 lines. The component itself is fine; the noise is Monaco configuration, language definitions, JOIN suggestion providers, and intention actions inlined alongside the React lifecycle.

What to extract

  1. monacoSetup.ts — theme registration, language token registration, editor option defaults.
  2. sqlCompletionProvider.ts — the JOIN-via-foreign-key autocomplete and the schema-aware identifier suggestions.
  3. intentionActions.ts — the Alt+Enter "intention actions" (quick fixes / refactors offered in the editor).
  4. liveTemplateProvider.ts — the snippet expansion that consumes useLiveTemplates.

Suggested approach

  • Files live in src/components/editor/ next to QueryEditor.tsx.
  • Each provider is a pure function that takes its dependencies (current schema, FK map, templates) and returns a Monaco-registered disposable.
  • QueryEditor.tsx orchestrates the disposables in a single useEffect.

Done criteria

  • QueryEditor.tsx drops below ~600 lines.
  • All editor features still work: JOIN suggestions, table/column autocomplete, Alt+Enter actions, live templates.
  • TypeScript / tests / build green.
  • One Vitest test for the live-template expander (pure-string logic).

Out of scope

  • Switching to a different editor (CodeMirror, etc.).
  • Adding language servers / LSP.

Audit reference

K5 in the pre-launch audit.

Lingua principale
TypeScript
Stelle
6
Fork
1
Merge medio
17m
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di openidle-dev/queryden

Tutte le issue di openidle-dev/queryden

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.