Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

@babel/core internal test skips fail when citgm run locally

Aperta
  • Qualcosa non va?
#1,194 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, nodejs
Ambito
testing-qa, tooling

Direzione di ricerca

Start with lib/lookup.json, where the per-package citgm entries such as @babel/core and jose define their skip settings. The failures are in packages/babel-traverse/test/traverse.js, around the deprecated-types and deprecated-aliases tests that expect a console warning. Check how citgm runs the suite outside Jenkins, where the temp directory differs from NODE_TEST_DIR. Done means the proposed CITGM environment variable is set for these runs and those two tests are skipped only when it is true.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Situation

When cigtm @babel/core is run outside of Node.js Jenkins CI, it fails to skip tests that it intended to skip for citgm.

error:                     |
error:                     | Summary of all failing tests
error:                     | FAIL packages/babel-traverse/test/traverse.js
error:                     | traverse > traverse.explode > deprecated types and aliases > should warn for deprecated node types
error:                     | Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)
error:                     |
error:                     | Expected: StringMatching /Visitor `NumberLiteral` has been deprecated, please migrate to `NumericLiteral`[^]+at.+testFn1/
error:                     |
error:                     | Number of calls: 0
error:                     | at testFn1 (file:///tmp/be09bd18/@babel/core/packages/babel-traverse/test/traverse.js?1791788834095:513:30)
error:                     | at async file:///tmp/be09bd18/@babel/core/node_modules/tinypool/dist/esm/entry/worker.js:72:20
error:                     |
error:                     | traverse > traverse.explode > deprecated types and aliases > should warn for deprecated aliases
error:                     | Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)
error:                     |
error:                     | Expected: StringMatching /Visitor `ModuleDeclaration` has been deprecated, please migrate to `ImportOrExportDeclaration`[^]+at.+testFn2/
error:                     |
error:                     | Number of calls: 0
error:                     | at testFn2 (file:///tmp/be09bd18/@babel/core/packages/babel-traverse/test/traverse.js?1791788834095:529:30)
error:                     | at async file:///tmp/be09bd18/@babel/core/node_modules/tinypool/dist/esm/entry/worker.js:72:20
error:                     |
error:                     |
error:                     | Test Suites: 1 failed, 275 passed, 276 total
error:                     | Tests:       2 failed, 16 skipped, 36969 passed, 36987 total

In Node.js Jenkins CI citgm-smoker sets:

temp="$NODE_TEST_DIR"/citgm_tmp

This is however not generally the case if citgm is run in GitHub Actions or on a local system.

In the above example from Ubuntu on GitHub Actions the temp directory is /tmp/be09bd18 and the tests are not skipped.

Suggestion

Add an environment variable CITGM set to true into

https://github.com/nodejs/citgm/blob/37e15454ddfe5aba91955062b7899114c528e7d1/lib/lookup.json#L2-L8

and skip tests in @babel/core based on this environment variable as necessary.

This is used by jose, for example:

https://github.com/nodejs/citgm/blob/37e15454ddfe5aba91955062b7899114c528e7d1/lib/lookup.json#L229-L235

cc: @nicolo-ribaudo @JLHwung @liuxingbaoyu

Lingua principale
JavaScript
Stelle
608
Fork
158
Merge medio
2g 17h
PR unite (30g)
18

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di nodejs/citgm

Tutte le issue di nodejs/citgm

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.