[Bug]: Files "Folder tree" navigation registers and renders one navigation view per folder (no virtualization): 12,490 DOM items, 7.1 s page load and a 2.3 s long task with 4,140 subfolders

Aperta
#65,905 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, typescript

Direzione di ricerca

Start with apps/files/src/views/folderTree.ts and apps/files/src/components/FilesNavigationListItem.vue, then reproduce with a folder containing 4,000+ subfolders using the browser Performance tools. The issue describes excessive navigation items and main thread blocking; a fix should keep the folder tree responsive and render or load children efficiently. The proposed approaches involve changes to tree ownership, loading, rendering, and indexing, so scope the design before implementation.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

0. Needs triage 34-feedback bug
⚠️ This issue respects the following points: ⚠️
  • This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
  • This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
  • I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
  • I agree to follow Nextcloud's Code of Conduct.
  • I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description

The "Folder tree" navigation view (Nextcloud 30+, apps/files/src/views/folderTree.ts) registers one navigation view per folder (Navigation.register(...views)) and the navigation panel renders one NcAppNavigationItem per view, recursively, without any virtualization. With a folder that contains 4,140 subfolders, opening it renders 12,490 items in the navigation panel, the page load goes from 0.82 s to 7.1 s, and the longest blocking task on open goes from 75 ms to 2.3 s (main thread frozen). The whole app stays sluggish afterwards because every reactive change re-evaluates childViews for every item.

Limiting the server response (see the companion server-side issue about ApiController::getChildren(), #65904) is not enough: the panel also registers the folders already loaded by the files list (updateTreeChildren() reuses the files store), so the cost is paid as soon as the folder is opened.

Actual behavior
Measurement (Chrome, same account, same folder with 4,140 subfolders) Folder tree enabled Folder tree disabled
Items rendered in the navigation panel 12,490 32
Page load of the folder with 4,140 subfolders 7.1 s 0.82 s
Page load of a project folder 3 levels below it (/<clients>/<client>/<project>/<subfolder>) 3.1 s 0.63 s
Longest blocking task on open 2.3 s 75 ms
Jump of the files list to a given entry 0.4–0.8 s 0.2–0.28 s

Server side, the folder-tree request itself is fast (~0.2 s with the fix proposed in #65904); the time is spent in the browser.

Root cause

apps/files/src/views/folderTree.ts (identical on stable34 and master):

Proposed fix
  1. Virtualize the tree panel (render only the visible rows, e.g. with vue-virtual-scroller which the Files app already ships, on a flattened array of { node, level, expanded }), or at least paginate children per node ("show more" beyond N entries).
  2. Lazy-load one level on expand only (depth=1), do not pre-register grandchildren, and do not turn every folder into a navigation IView: keep one view for the tree and let the component own its node tree.
  3. Index children by parent once (a Map<parentId, IView[]>) instead of filtering all views per item.
  4. Sort with a cached Intl.Collator (numeric, base sensitivity).

Feasibility: a quick prototype injected into the same page (virtualized list in place of the panel content, same look) on the same 4,140 subfolders renders 24 items instead of 12,490, first paint in 85 ms, 67 ms per scroll jump, and sorts the 4,140 names in 1.3 ms with Intl.Collator, with the same order as the files list.

Steps to reproduce
  1. Create a folder with 4,000+ subfolders (empty subfolders are enough).
  2. Keep the default "Enable folder tree" setting (Files → settings).
  3. Open that folder in the Files app with the browser's performance tools recording (Long Tasks / Performance tab).
  4. Count the items in the left navigation panel (document.querySelectorAll('[data-cy-files-navigation-item]').length).
  5. Compare with the same folder after disabling the folder tree (occ user:setting <uid> files folder_tree 0, reload).
Expected behavior

The navigation panel should render only the visible rows (virtualized or paginated list), load children lazily on expand only, and never block the main thread for seconds. Opening a folder should cost about the same with or without the folder tree.

Nextcloud Server version

34

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.4

Web server

Other

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info
  • Nextcloud Server 34.0.3 — folderTree.ts unchanged on master as of 2026-10-24 (3c5546a1a84230af62c981e9512d977656ee459c) and on stable34 (07b7a0f600708c90ba94ede238818c215536d4bf). The folder tree view was introduced by #46596 / #47122 (Nextcloud 30); #58273 (Nextcloud 34) reuses the files store but does not change the one-view-per-folder design.
  • Server: Ubuntu 24.04 LTS, PHP 8.4, PostgreSQL 16, Caddy 2 (FastCGI to php-fpm — hence "Other" above). Client: Chrome, current stable.
  • The only workaround today is to disable the folder tree per account (occ user:setting <uid> files folder_tree 0), which removes the feature; the default is hard-coded to true (apps/files/lib/Service/UserConfig.php), so new accounts get it back.
  • Companion server-side issue: #65904 (the API computes and discards the listings of all subfolders).
  • Measurement protocol: PerformanceObserver on longtask entries + time to first rendered rows; happy to share the script and to test a fix on the real tree.
Lingua principale
PHP
Stelle
37.5k
Fork
5.4k
Merge medio
1g 13h
PR unite (30g)
639

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di nextcloud/server

Tutte le issue di nextcloud/server

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.