`animation: var(--a)` over `spin 1s step-end` or `spin 1s EASE-IN` writes no animation

Aperta
  • Qualcosa non va?
#530 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 12 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react-native, typescript
Ambito
frontend

Direzione di ricerca

Start with the reproduction in src/__tests__/native/animation-shorthand-keywords.test.tsx, then trace how animation: var(--a) is parsed when variables are kept rather than folded. Run yarn jest src/__tests__/native/animation-shorthand-keywords.test.tsx to compare the reported easing cases. Done when the kept route preserves the animation name and easing for EASE-IN, step-end, and step-start, matching the folded route.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Before submitting a new issue
  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.
Bug summary

animation: var(--a) over spin 1s step-end, spin 1s step-start or spin 1s EASE-IN writes no animation at all on the kept route, where the folded route runs spin with that easing; spin 1s ease-in and spin 1s linear run on both.

spin 1s ease-in (folded): name=true timing="ease-in" duration=[1000]
spin 1s ease-in (kept): name=true timing="ease-in" duration=1000
spin 1s EASE-IN (folded): name=true timing="ease-in" duration=[1000]
spin 1s EASE-IN (kept): name=false timing=undefined duration=undefined
spin 1s step-end (folded): name=true timing={"stepsNumber":1,"modifier":"end"} duration=[1000]
spin 1s step-end (kept): name=false timing=undefined duration=undefined
spin 1s step-start (folded): name=true timing={"stepsNumber":1,"modifier":"start"} duration=[1000]
spin 1s step-start (kept): name=false timing=undefined duration=undefined
spin 1s linear (folded): name=true timing="linear" duration=[1000]
spin 1s linear (kept): name=true timing="linear" duration=1000

Expected: the kept route runs spin with the folded route's easing in every case.

Library version

main at 2421ea7 (0.0.0-nightly.2421ea7)

Environment info
System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 155.26 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.9.2
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK:
    API Levels:
      - "33"
      - "35"
      - "35"
      - "35"
      - "36"
      - "37"
    Build Tools:
      - 35.0.0
      - 36.0.0
      - 36.1.0
      - 37.0.0
    System Images:
      - android-26 | Google APIs Intel x86_64 Atom
      - android-28 | Google APIs Intel x86_64 Atom
      - android-29 | Google APIs Intel x86_64 Atom
      - android-30 | Google APIs Intel x86_64 Atom
      - android-31 | Google APIs Intel x86_64 Atom
      - android-32 | Google APIs Intel x86_64 Atom
      - android-33 | Google APIs Intel x86_64 Atom
      - android-34 | Google APIs Intel x86_64 Atom
      - android-35 | Google APIs Intel x86_64 Atom
      - android-36.1 | Google Play Intel x86_64 Atom
      - android-36.1 | Pre-Release 16 KB Page Size Google Play Intel x86_64 Atom
      - android-37.0 | Google APIs Intel x86_64 Atom
    Android NDK: Not Found
  Windows SDK: Not Found
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.86.3
    wanted: 0.86.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
Steps to reproduce
  1. Clone the reproducer branch, which is main at 2421ea7 with one file added, src/__tests__/native/animation-shorthand-keywords.test.tsx, and install: 
    git clone --branch repro/530-held-animation-drops-on-step-or-uppercase-easing https://github.com/YevheniiKotyrlo/react-native-css
cd react-native-css
yarn install
  2. Run yarn jest src/__tests__/native/animation-shorthand-keywords.test.tsx.

src/__tests__/native/animation-shorthand-keywords.test.tsx:

// Run from a react-native-css checkout: copy to src/__tests__/native/animation-shorthand-keywords.test.tsx, then `yarn jest` it.
import { StyleSheet } from "react-native";

import { render, screen } from "@testing-library/react-native";
import { View } from "react-native-css/components/View";
import { registerCSS, testID } from "react-native-css/jest";

jest.mock("../../native/reanimated", () => ({
  animatedComponentFamily: (component: unknown) => component,
}));

const keyframes = `@keyframes spin { from { opacity: 0; } to { opacity: 1; } }`;

test.each(["spin 1s ease-in", "spin 1s EASE-IN", "spin 1s step-end", "spin 1s step-start", "spin 1s linear"])("animation: var(--a) over %s", (value) => {
  for (const inlineVariables of [true, false]) {
    registerCSS(`${keyframes} .a { --a: ${value}; animation: var(--a); }`, inlineVariables ? {} : { inlineVariables: false });
    render(<View testID={testID} className="a" />);
    const style = StyleSheet.flatten(screen.getByTestId(testID).props.style) as Record<string, unknown> | undefined;
    console.log(`${value} (${inlineVariables ? "folded" : "kept"}): name=${JSON.stringify(style?.animationName) !== undefined} timing=${JSON.stringify(style?.animationTimingFunction)} duration=${JSON.stringify(style?.animationDuration)}`);
    screen.unmount();
  }
});

Expected: animation: var(--a) over spin 1s step-end, spin 1s step-start or spin 1s EASE-IN runs spin with that easing, as the folded route does.

Actual: no animation is written on the kept route.

The run's output on main at 2421ea7, Windows 11, Node 26.12.1 
  console.log
    spin 1s ease-in (folded): name=true timing="ease-in" duration=[1000]
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s ease-in (kept): name=true timing="ease-in" duration=1000
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s EASE-IN (folded): name=true timing="ease-in" duration=[1000]
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s EASE-IN (kept): name=false timing=undefined duration=undefined
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s step-end (folded): name=true timing={"stepsNumber":1,"modifier":"end"} duration=[1000]
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s step-end (kept): name=false timing=undefined duration=undefined
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s step-start (folded): name=true timing={"stepsNumber":1,"modifier":"start"} duration=[1000]
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s step-start (kept): name=false timing=undefined duration=undefined
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s linear (folded): name=true timing="linear" duration=[1000]
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
  console.log
    spin 1s linear (kept): name=true timing="linear" duration=1000
      at log (src/__tests__/native/animation-shorthand-keywords.test.tsx:19:13)
PASS src/__tests__/native/animation-shorthand-keywords.test.tsx
  √ animation: var(--a) over spin 1s ease-in (32 ms)
  √ animation: var(--a) over spin 1s EASE-IN (5 ms)
  √ animation: var(--a) over spin 1s step-end (5 ms)
  √ animation: var(--a) over spin 1s step-start (3 ms)
  √ animation: var(--a) over spin 1s linear (4 ms)
Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total
Snapshots:   0 total
Time:        1.118 s, estimated 3 s
Ran all test suites matching /src\\__tests__\\native\\animation-shorthand-keywords.test.tsx/i.
Reproducible example repository

https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/530-held-animation-drops-on-step-or-uppercase-easing

Lingua principale
TypeScript
Stelle
166
Fork
45
Merge medio
17g 22h
PR unite (30g)
3

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di nativewind/react-native-css

Tutte le issue di nativewind/react-native-css

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.