Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

SafeAreaView is re-exported unwrapped from the safe-area-context shim: className silently no-ops (breaks flex-1 screen roots after v4 -> v5 migration)

Aperta
#386 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

@nimbly1 ci sta già lavorando.

Dal 4/10/2026.

  • #468 di @nimbly1 — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
28/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
react-native, typescript
Ambito
frontend, mobile

Direzione di ricerca

The bug is in the shim at src/components/react-native-safe-area-context.native.tsx, which re-exports SafeAreaView unwrapped, so className is dropped. Read how the other intercepted components are wrapped in that file, then check whether linked PR #468 already covers this before starting. Done means className on SafeAreaView maps to style, with a test or on-device check showing a flex-1 root fills the screen.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

auto-triaged bug confirmed

Summary

The react-native-safe-area-context shim wraps SafeAreaProvider (to expose the inset CSS variables) but re-exports everything else from the original package unwrapped:

// src/components/react-native-safe-area-context.native.tsx
export * from "react-native-safe-area-context";

export function SafeAreaProvider({ children, ...props }: SafeAreaProviderProps) { ... }

SafeAreaView is therefore the original component, and className on it is a silent no-op — no warning, no error.

Why this is painful

<SafeAreaView className="flex-1 ..."> is an extremely common screen-root pattern in NativeWind v4 apps (the v4 JSX transform made it work on any component). After migrating to NativeWind v5 / react-native-css, every such screen root silently loses flex: 1, the SafeAreaView collapses to content height, and ScrollViews inside shrink to zero — the entire screen body renders blank while headers/tab bars (styled via style objects) keep working.

Nothing catches it statically: tsc, jest, and expo export are all green (the CSS compiles fine; it just never reaches the component). We only found it via on-simulator UAT. In our app it affected 44 SafeAreaView className call sites, i.e. every screen.

Environment

  • react-native-css 3.0.7, nativewind 5.0.0-preview.4, tailwindcss 4.3.3
  • Expo SDK 57, React Native 0.86, New Architecture enabled, pnpm monorepo (hoisted)
  • Metro via withNativewind(config, { inlineVariables: false }), default globalClassNamePolyfill (true)

Repro

import { SafeAreaView } from "react-native-safe-area-context";

export default function Screen() {
  return (
    <SafeAreaView className="flex-1 bg-red-500">
      <Text>never gets a red full-height background</Text>
    </SafeAreaView>
  );
}

<View className="flex-1 bg-red-500"> in the same tree styles correctly, confirming the CSS pipeline itself works.

Suggested fix

Wrap SafeAreaView in the shim like the other intercepted components, e.g.:

import { SafeAreaView as OriginalSafeAreaView } from "react-native-safe-area-context";
import { useCssElement } from "react-native-css";

export function SafeAreaView(props: SafeAreaViewProps & { className?: string }) {
  return useCssElement(OriginalSafeAreaView, props, { className: "style" });
}

We are currently shipping exactly that as a local pnpm patch on dist/ (module + commonjs) and it fully restores v4 behavior — all screens render identically to our NativeWind 4 baseline.

More generally: a dev-mode warning when className is passed to a component that nothing intercepts would have turned a multi-hour debugging session into a one-line console message. Happy to open a PR for the SafeAreaView wrap if useful.

Lingua principale
TypeScript
Stelle
166
Fork
45
Merge medio
13g 14h
PR unite (30g)
1

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di nativewind/react-native-css

Tutte le issue di nativewind/react-native-css

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.