Windows: endpoints hang or crash when several bind at once (concurrent WMI default-route queries?)
I maintainer di solito rispondono entro 2 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 55/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- rust
- Ambito
- backend, networking
Direzione di ricerca
Start with src/interfaces/windows.rs and inspect get_default_route, which the issue identifies as the WMI query path. Compare it with the reported GetIpForwardTable2(AF_INET) approach and check how Windows dependencies and route detection are handled. Done means concurrent endpoint binds no longer hang or crash on Windows while default route detection retains the described behavior.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Describe the bug
We're seeing this in our project and wanted to share it in case it's useful.
On Windows, when several iroh endpoints are created at the same time in one process, Endpoint::bind()
sometimes hangs (it never returns) or the process crashes. In our CI, a test that binds five endpoints at once
on loopback failed in about 3 of every 4 runs on GitHub's Windows runners. It never fails on Linux or macOS.
This looks related to #124, but it still happens with the spawn_blocking fix from #127 (we're on 0.19.3).
The difference here is several WMI queries running at the same time, one per netmon::Monitor.
What we found:
- The hangs and crashes happen inside the WMI query that
interfaces::windows::get_default_routeruns over
COM (Win32_IP4RouteTable). With full page heap enabled, our runs stopped on freed memory inside COM during
those queries (combase!OXIDEntry::DecRefCnt,CROIDTable::ClientDeRegisterOIDFromPingServer, and once in
an already unloadedwbemprox.dll). - Initializing COM ourselves first (MTA, security) and keeping a WMI connection open didn't help.
- Reading the route table with
GetIpForwardTable2(AF_INET)and checking for a route with prefix length 0
avoids COM entirely. With only that change, the failures stopped: our Windows CI has passed every run since,
including repeated runs of the same commit.
A side note we noticed: Win32_IP4RouteTable.Name is the route's destination, not an interface name, so on
Windows default_route_interface is always "0.0.0.0". The replacement below keeps that value, so
is_major_change behaves the same. Returning the real interface (the row's InterfaceIndex) could be a
follow-up.
This is the replacement we're using in a patched copy (it drops the wmi and serde dependencies on
Windows):
fn get_default_route() -> Result<DefaultRouteDetails, Error> {
let mut table: *mut MIB_IPFORWARD_TABLE2 = std::ptr::null_mut();
// SAFETY: Windows allocates the table and returns it in `table`.
unsafe { GetIpForwardTable2(AF_INET, &mut table) }.ok()?;
// SAFETY: on success `table` points to `NumEntries` rows, read here only, and freed once below.
let found = unsafe {
let rows = std::slice::from_raw_parts((*table).Table.as_ptr(), (*table).NumEntries as usize);
let found = rows.iter().any(|row| row.DestinationPrefix.PrefixLength == 0);
FreeMibTable(table.cast());
found
};
if !found {
return Err(e!(Error::NoRoute));
}
Ok(DefaultRouteDetails { interface_name: "0.0.0.0".to_string() })
}
(still called through tokio::task::spawn_blocking, as now.)
The full change is here: https://github.com/alexpacheli/hext-remote/tree/main/vendor/netwatch (see
PATCHED.md and src/interfaces/windows.rs).
Relevant Logs
No useful trace logs: the process just stops inside the WMI query. The page heap stacks are the ones above.
Expected behavior
Several endpoints can bind at the same time on Windows without hanging or crashing.
netwatch, portmapper
Version: netwatch 0.19.3 (through iroh 1.4.1), wmi 0.18.4
Platform(s)
Desktop:
- OS: Windows Server 2025 (GitHub Actions
windows-2025runner) - Version: x86_64-pc-windows-msvc
Additional Context / Screenshots / GIFs
Happy to test a fix or provide more details. The investigation was done with the help of an AI coding
assistant; the results above (the failures and the fix) come from our CI runs.
lolwut
- This issue was created by a human that thought critically about
the issue being reported and wrote this as concisely and clearly
as they could. Taking full responsibility for the issue being
accurate. - This issue isn't slop, and is backed up by evidence.
- Lingua principale
- Rust
- Stelle
- 34
- Fork
- 56
- Merge medio
- 2g 4h
- PR unite (30g)
- 8
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Nessuna guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di n0-computer/net-tools
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 33/100
n0-computer/net-tools#280 ·
I maintainer di solito rispondono entro 2 giorni
-
netwatch: objc2-system-configuration with default features pulls objc2-security into every macOS buildForse già presa @flub l’ha presa 1 giorno fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 25/100
n0-computer/net-tools#278 · 2 commenti ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
n0-computer/net-tools#276 ·
I maintainer di solito rispondono entro 2 giorni
-
netwatch never turns on noq-udp's Apple fast path, so iroh's `fast-apple-datapath` does nothingAperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
n0-computer/net-tools#272 ·
I maintainer di solito rispondono entro 2 giorni
-
portmapper: synchronous HomeRouter lookup blocks the Tokio workerForse già presa @TNTcraftHIM l’ha presa 19 giorni fa. Apertaready-for-pr
Difficoltà 3/5 1-2 giorni Idoneità per principianti 50/100
n0-computer/net-tools#266 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di n0-computer/net-tools
Issue simili
-
area:web kind:bug priority:p2 ready
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
sims1253/ry#931 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 84/100
sims1253/r-typeshed#140 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
storytold/craft-libs#2867 ·
I maintainer di solito rispondono entro 1 giorno
-
help wanted needs investigation priority: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100